From 7b5601eeb52f0eab55c5b5577f90b2ecc7f26dd9 Mon Sep 17 00:00:00 2001
From: Martin Kosek <mkosek@redhat.com>
Date: Wed, 12 Jan 2011 14:17:30 +0100
Subject: Potential memory leaks in ipa-getkeytab

This patch fixes 2 situations where a pointer to allocated error
string could be overwritten - which could have resulted in
a memory leak.

https://fedorahosted.org/freeipa/ticket/714
---
 ipa-client/ipa-getkeytab.c | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'ipa-client/ipa-getkeytab.c')

diff --git a/ipa-client/ipa-getkeytab.c b/ipa-client/ipa-getkeytab.c
index e4c7b0e2..ec923096 100644
--- a/ipa-client/ipa-getkeytab.c
+++ b/ipa-client/ipa-getkeytab.c
@@ -245,6 +245,7 @@ static int prep_ksdata(krb5_context krbctx, const char *str,
                                             &similar);
             if (krberr) {
                 free_keys_contents(krbctx, keys);
+                free(ksdata);
                 fprintf(stderr, _("Enctype comparison failed!\n"));
                 return 0;
             }
@@ -707,6 +708,7 @@ static int ldap_set_keytab(krb5_context krbctx,
 	ldap_controls_free(srvctrl);
 	ldap_msgfree(res);
 	ldap_unbind_ext(ld, NULL, NULL);
+	free(encs);
 	return kvno;
 
 error_out:
-- 
cgit