From 31054b5ebd53a9bf57a1e847d1cb232eb27d3b69 Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Wed, 4 Jun 2008 13:44:08 -0400 Subject: Under some conditions rl may not have been initialized so the config may error out with: UnboundLocalError: "local variable 'rl' referenced before assignment" This is caught and ignored but the result is that the records in DNS may not be used at all. Initializing rl to zero fixes this. I also convert the server list into a set to make each entry unique (and back to a list because that is what we are supposed to return) 433506 --- ipa-python/config.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ipa-python/config.py b/ipa-python/config.py index 4671faf9..5a9770e8 100644 --- a/ipa-python/config.py +++ b/ipa-python/config.py @@ -78,6 +78,7 @@ def __parse_config(): pass def __discover_config(): + rl = 0 try: if not config.default_realm: krbctx = krbV.default_context() @@ -163,6 +164,8 @@ def init_config(args=None): __parse_config() __discover_config() + config.default_server = list(set(config.default_server)) + if not config.default_realm: raise IPAConfigError("IPA realm not found in DNS, in the config file (/etc/ipa/ipa.conf) or on the command line.") if not config.default_server: -- cgit