diff options
author | Jason Gerard DeRose <jderose@redhat.com> | 2008-09-24 05:46:49 +0000 |
---|---|---|
committer | Jason Gerard DeRose <jderose@redhat.com> | 2008-09-24 05:46:49 +0000 |
commit | 15b83ab1bf9d94e4f5cf292623d194b6a8094616 (patch) | |
tree | b2486d547435b067e7cb89b858057bfb210b00d2 | |
parent | 126b31de5581f4107d7d863f606a9adfa782f88a (diff) | |
download | freeipa-15b83ab1bf9d94e4f5cf292623d194b6a8094616.tar.gz freeipa-15b83ab1bf9d94e4f5cf292623d194b6a8094616.tar.xz freeipa-15b83ab1bf9d94e4f5cf292623d194b6a8094616.zip |
329: Command.convert() now converts all keys, not just keys in params
-rw-r--r-- | ipalib/frontend.py | 11 | ||||
-rw-r--r-- | ipalib/tests/test_frontend.py | 2 |
2 files changed, 3 insertions, 10 deletions
diff --git a/ipalib/frontend.py b/ipalib/frontend.py index cb18a07a..fc397530 100644 --- a/ipalib/frontend.py +++ b/ipalib/frontend.py @@ -299,15 +299,10 @@ class Command(plugable.Plugin): for option in self.get_options(): yield create_param(option) - def __convert_iter(self, kw): - for (key, value) in kw.iteritems(): - if key in self.params: - yield (key, self.params[key].convert(value)) - else: - yield (key, value) - def convert(self, **kw): - return dict(self.__convert_iter(kw)) + return dict( + (k, self.params[k].convert(v)) for (k, v) in kw.iteritems() + ) def __normalize_iter(self, kw): for (key, value) in kw.iteritems(): diff --git a/ipalib/tests/test_frontend.py b/ipalib/tests/test_frontend.py index 4ddf11b3..db831caa 100644 --- a/ipalib/tests/test_frontend.py +++ b/ipalib/tests/test_frontend.py @@ -486,8 +486,6 @@ class test_Command(ClassChecker): kw = dict( option0='option0', option1='option1', - whatever=False, - also=object, ) expected = dict(kw) expected.update(dict(option0=u'option0', option1=u'option1')) |