From 6b3b9009af5c85b0be9dea36aca86c93972a20a4 Mon Sep 17 00:00:00 2001 From: Nathan Kinder Date: Fri, 17 Sep 2010 14:37:47 -0700 Subject: Bug 630092 - (cov#12105) Resource leak in pwdscheme config code We don't free new_scheme if the password encode function is not set. We need to free new_scheme in this error case. --- ldap/servers/slapd/libglobs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ldap/servers/slapd/libglobs.c b/ldap/servers/slapd/libglobs.c index f36588cb..b88a69a8 100644 --- a/ldap/servers/slapd/libglobs.c +++ b/ldap/servers/slapd/libglobs.c @@ -1600,7 +1600,6 @@ config_set_pw_storagescheme( const char *attrname, char *value, char *errorbuf, } retVal = LDAP_OPERATIONS_ERROR; slapi_ch_free_string(&scheme_list); - free_pw_scheme(new_scheme); return retVal; } else if ( new_scheme->pws_enc == NULL ) @@ -1616,6 +1615,7 @@ config_set_pw_storagescheme( const char *attrname, char *value, char *errorbuf, } retVal = LDAP_UNWILLING_TO_PERFORM; slapi_ch_free_string(&scheme_list); + free_pw_scheme(new_scheme); return retVal; } -- cgit