summaryrefslogtreecommitdiffstats
path: root/ldap
Commit message (Collapse)AuthorAgeFilesLines
...
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-2/+1
| | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Pointer "replica" returned by "object_get_data(prp->replica_object)" (line 502) is never used. In "case STATE_READY_TO_ACQUIRE", Replica object "replica" is not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-3/+1
| | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The return value from object_get_data is assigend to ruv just to check if repl_ruv object exists or not with PR_ASSERT in the DEBUG mode (line 218). Passing the object_get_data call to PR_ASSERT directly.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-3/+2
| | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Pointer "replica" returned by "object_get_data(prp->replica_object)" (line 826) is never used. In "case STATE_READY_TO_ACQUIRE", Replica object "replica" is not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-1/+1
| | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The "bval" assignment on line 636 can be removed because any value is accepted. Note: This is to set debug mode "cb_set_debug(1)" which is enabled by having nsDebug in the chaining config entry.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-6/+6
| | | | | | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The "ptr" assignment on line 2622 is unnecessary because the value is never used. The "word" assignment on line 2630 can be removed because the first token is ignored. Alternatively the value should be validated. The "ptr" assignment on line 1456 is unnecessary because the value is not used. The "word" assignment on line 1463 can be removed because the first token is ignored. Alternatively the value should be validated. The "ptr" assignment on line 1210 is unnecessary because the value is never used. The "word" assignment on line 1217 can be removed because the first token is ignored. Alternatively the value should be validated.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-6/+6
| | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The "word" assignment on line 961 and 963 is unnecessary because the value will be overwritten. Comment: The "s" assignments on line 271, 280, and 281 are unnecessary because the value is never used.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-2/+0
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The call to strchr() is unnecessary because strcpy() will ensure that string p is NULL-terminated.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-1/+1
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The str assignment on line 1240 can be removed because the value is not needed or will be overwritten.
* Bug 622628 - fix coverity Defect Type: Integer handling issuesNoriko Hosoi2010-08-111-3/+4
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622628 Comment: There is a suspicious implicit sign extension. Instead of direct bit shifting, use ntohl to decode buffer length.
* Bug 622628 - fix coverity Defect Type: Integer handling issuesNoriko Hosoi2010-08-101-1/+1
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622628 Comment: slapd_system_strerror does not cover the return codes from the libdb functions. Instead, use dblayer_strerror for describing error number.
* Bug 622628 - fix coverity Defect Type: Integer handling issuesNoriko Hosoi2010-08-101-1/+3
| | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622628 Comment: This is a typo where a bitwise AND was used instead of a logical AND on line 2185. The issue is not serious, as it only affect the "number of operations" counter for ldclt. The second half of the condition is not even needed in fact, since we are guaranteed that "(ret == LDAP_ALREADY_EXISTS)" is true at line 2185. Fix Description: Based upon the comment, removing the unnecessary second half of the condition.
* Bug 194531 - db2bak is too noisyNoriko Hosoi2010-08-107-34/+85
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=194531 Description: Introduced "-q" option to suppress the backing up/ restoring message for each db file. Usage: db2bak [archivedir] [-q] [-h] Usage: bak2db archivedir [-n backendname] [-q] | [-h] If "-q" is specified, the verbose messages are not prited to the standard error, but just to the errors log. In addition, new log level SLAPI_LOG_BACKLDBM/LDAP_DEBUG_BACKLDBM has been introduced.
* 621928 - Unable to enable replica (rdn problem?) on 1.2.6 rc6Noriko Hosoi2010-08-092-13/+271
| | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=621928 Description: RUV (nsuniqueid=ffffffff-ffffffff-ffffffff-ffffffff,<suffix>) needs to be allowed to add to the DB before <suffix> is added. To allow it, entryrdn prepares the rdn exception list (rdn_exceptions). If the to-be-added entry (in this case RUV; and currently only RUV is in the list) is in the list, <suffix> is added to the entryrdn index with the temporary entry ID 0 (note: not to the primary db file id2entry.db#). When the suffix is indeed added to the DB, the temporary ID 0 is replaced with the given real ID.
* 513166 - Simple Paged result doesn't provide the server's estimateNoriko Hosoi2010-08-048-6/+81
| | | | | | | | | | | | | | | | | of the total number of entries https://bugzilla.redhat.com/show_bug.cgi?id=513166 Description: By definition, the first integer of the response control is for the estimated search result set size. This fix sets the estimated result set size. * controlType = LDAP_CONTROL_PAGEDRESULTS; * criticality = n/a; * controlValue: * realSearchControlValue ::= SEQUENCE { * size INTEGER (0..maxInt), * -- result set size estimate from server * cookie OCTET STRING
* Bug 617862 - Replication: Unable to delete tombstone errorsRich Megginson2010-08-031-1/+1
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617862 Resolves: bug 617862 Bug Description: Replication: Unable to delete tombstone errors Reviewed by: nhosoi (Thanks!) Branch: master Fix Description: In the case of deletion of a tombstone entry, the target entry 'e' is the tombstone entry. 'tombstone' is not used for this purpose. Platforms tested: RHEL5 x86_64 Flag Day: no Doc impact: no (cherry picked from commit 84e6cc2ffd7a3aa684959d22e6fc2ab3a15791de)
* Bug 617629 - Missing aliases in new schema filesRich Megginson2010-08-023-38/+57
| | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617629 Resolves: bug 617629 Bug Description: Missing aliases in new schema files Reviewed by: nkinder (Thanks!) Branch: master Fix Description: add back the aliases we removed - added a new schema flag X-DEPRECATED - this is a quoted string containing a space separated list of the deprecated aliases for this attribute Platforms tested: RHEL5 x86_64 Flag Day: no Doc impact: no (cherry picked from commit 34c4ab700d99e455ba3523e7d7a02e4eae401d3d)
* 619595 - Upgrading sub suffix under non-normalized suffix disappearsNoriko Hosoi2010-07-292-42/+29
| | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619595 Fix Description: The cause of this problem is the config attribute nsslapd-parent-suffix was not defined as an attribute of DN syntax. Because of the missing definition, the value is not the target of the DN normalization and the match fails after upgraded. Adding the attribute to the schema solves this problem. Plus upgradedb does backup the DB before upgrade, and if it fails it restores from the backed up DB. Use dblayer_restore instead of copying DB files one by one.
* 616608 - SIGBUS in RDN index reads on platforms with strict alignmentsNoriko Hosoi2010-07-274-91/+126
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=616608 Fix description: Use the marshall/unmarshall technique for the entryrdn index data. Introduced sizeushort_internal_to_stored/sizeushort_stored_to_internal for the size data to store in 2 bytes. Entryrdn related functions in the dbscan utility are also modified to support marshalled data. Reviewed by ulf.weltman@hp.com and fixed bugs found by him.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-65/+61
| | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11958 NO_EFFECT Triaged Unassigned Bug Moderate Fix Required do_bind() ds/ldap/servers/slapd/bind.c Comment: slapi_dn_normalize_ext() may return a negative value but rc is of type ber_tag_t which is an unsigned int. Introducing "ber_tag_t ber_rc" just for ber functions and "int rc" for the rest.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-2/+0
| | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11843 DEADCODE Triaged Unassigned Bug Minor Fix Required mm_init() ds/ldap/servers/slapd/tools/mmldif.c Comment: A variable tailorfile is not used. Remove it.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-6/+47
| | | | | | | | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11841 DEADCODE Triaged Unassigned Bug Minor Fix Required sasl_map_new_private() ds/ldap/servers/slapd/sasl_map.c Comment: This new_lock NULL checking is not needed. On this path, the condition "NULL == new_lock" cannot be true. 97 if (NULL == new_lock) { Execution cannot reach this statement "slapi_ch_free((void**)new_p...". 98 slapi_ch_free((void**)new_priv); 99 return NULL; 100 } 11842 DEADCODE Triaged Unassigned Bug Minor Fix Required sasl_map_insert_list_entry() ds/ldap/servers/slapd/sasl_map.c Comment: In sasl_map_insert_list_entry, /* Check to see if it's here already */ was not implemented. The variable ishere pointed by coverity should have been prepared for the purpose. Implementing a helper function sasl_map_cmp_data.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-8/+9
| | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11834 DEADCODE Triaged Unassigned Bug Minor Fix Required write_function() ds/ldap/servers/slapd/daemon.c Comment: The location of checking for sentbytes is not correct. Execution cannot reach this statement "if (sentbytes < count){ {...". 1724 } else if (sentbytes < count) { 1725 LDAPDebug(LDAP_DEBUG_CONNS, It should not be "else" of checking for "bytes". Moving the check after "else if (sentbytes > count)".
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-4/+2
| | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11832 DEADCODE Triaged Unassigned Bug Minor Fix Required do_modrdn() ds/ldap/servers/slapd/modrdn.c Comment: At the line 201 and 212, the condition "rawnewsuperior" cannot be false. 201 rawnewsuperior?rawnewsuperior:"", 212 rawnewsuperior?rawnewsuperior:"", This patch is removing the checks.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-12/+9
| | | | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11831 DEADCODE Triaged Unassigned Bug Minor Fix Required config_set_value() ds/ldap/servers/slapd/libglobs.c Comment: The config_set_value meant to set various values (e.g. "off" and "unknown") depending upon the config_var_type, but this code overrides the spec and set the empty string to all cases. - /* for null values, just set the attr value to the empty - string */ - if (!value) { - slapi_entry_attr_set_charptr(e, cgas->attr_name, ""); - return; - } This patch removes the above blind empty string setting and relies on the values in each config_var_type case. Plus, adding the NULL value check to CONFIG_CHARRAY.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-9/+9
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11829 DEADCODE Triaged Unassigned Bug Minor Fix Required ldbm_back_start() ds/ldap/servers/slapd/back-ldbm/start.c Comment: The code meant the autosized cache should be reduced 25% if the calculated size was less than 500MB for the overhead of libdb. If larger than 500MB, the overhead is relatively small and can be ignored. The code should have calculated the size before comparing it to 500MB.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-1/+1
| | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11826 DEADCODE Triaged Unassigned Bug Minor Fix Required ldbm_back_search() ds/ldap/servers/slapd/back-ldbm/ldbm_search.c Comment: On this path, the condition "abandoned" cannot be true. 504 return ldbm_back_search_cleanup(pb, li, sort_control, 505 (abandoned?-1:LDAP_PROTOCOL_ERROR), 506 "Sort Response Control", -1, 507 &basesdn, &vlv_request_control); Line 505 should be 505 LDAP_PROTOCOL_ERROR,
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-8/+1
| | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11825 DEADCODE Triaged Unassigned Bug Minor Fix Required ldbm_back_modrdn() ds/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c Comment: It was checking if (parententry && parententry->ep_entry) in the if ( parententry == NULL ) clause. Removed the unnecessary code.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-4/+0
| | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11821 DEADCODE Triaged Unassigned Bug Minor Fix Required allinstance_set_busy() ds/ldap/servers/slapd/back-ldbm/misc.c 11822 DEADCODE Triaged Unassigned Bug Minor Fix Required allinstance_set_not_busy() ds/ldap/servers/slapd/back-ldbm/misc.c Comment: objset_next_obj releases the previous object internally. Thus, there is no leak. Just remove the 2 lines: if (inst_obj) object_release(inst_obj);
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-2/+1
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11820 DEADCODE Triaged Unassigned Bug Minor Fix Required idl_new_delete_key() ds/ldap/servers/slapd/back-ldbm/idl_new.c Comment: tmpid is no longer used. Since we don't define DB_ALLIDS_ON_WRITE, ALLID has no chance to be stored in the db. But the code should be fixed as follows: Remove: 480 ID tmpid = 0; The 496 must be 496 if (id == ALLID) {
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-3/+1
| | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11818 DEADCODE Triaged Unassigned Bug Minor Fix Required agt_mopen_stats() ds/ldap/servers/slapd/agtmmap.c Comment: Removing the unreachable statement: Execution cannot reach this statement "return 0;". 313 return 0;
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-1/+0
| | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11817 DEADCODE Triaged Unassigned Bug Moderate Fix Required NSUniqueAttr_Init() ds/ldap/servers/plugins/uiduniq/uid.c Comment: NSUniqueAttr_Init declared err twice. One at the top and another in BEGIN - END (do - while loop). The second err in the do - while loop is trashed when it gets out of the loop. Regardless of the result in the do - while loop, err = 0 (success) was returned to the caller. We are removing the second err in the BEGIN (== do - while) scope. 945 int err;
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-1/+0
| | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11816 DEADCODE Triaged Unassigned Bug Moderate Fix Required NS7bitAttr_Init() ds/ldap/servers/plugins/uiduniq/7bit.c Comment: NS7bitAttr_Init declared err twice. One at the top and another in BEGIN - END (do - while loop). The second err in the do - while loop is trashed when it gets out of the loop. Regardless of the result in the do - while loop, err = 0 (success) was returned to the caller. We are removing the second err in the BEGIN (== do - while) scope. 692 int err;
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-4/+0
| | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11815 DEADCODE Triaged Unassigned Bug Minor Fix Required distinguishedname_validate() ds/ldap/servers/plugins/syntaxes/validate.c Comment: A variable val_copy is declared and initialized, but not used. We remove these lines: 364 char *val_copy = NULL; 403 if (val_copy) { Execution cannot reach this statement "slapi_ch_free_string(&val_c...". 404 slapi_ch_free_string(&val_copy); 405 }
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-5/+5
| | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11814 DEADCODE Triaged Unassigned Bug Moderate Fix Required string_filter_sub() ds/ldap/servers/plugins/syntaxes/string.c Comment: A code to update tmpbufsize was missing. This "tpbufsize = len + 1;" is needed before slapi_ch_realloc. 351 tmpbufsize = len + 1; 352 tmpbuf = (char *) slapi_ch_realloc( tmpbuf, tmpbufsize ); Also, if (len < tmpbufsize) were true (could not be true since tmpbufsize never have been set), bvp->bv_val was copied to buf which is not long enough for bvp->bv_val. The bug was also fixed.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-1/+1
| | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11813 DEADCODE Triaged Unassigned Bug Minor Fix Required send_dirsync_search() ds/ldap/servers/plugins/replication/windows_connection.c Comment: op_string points to a static string: 731 op_string = "search"; We don't need to check op_string in slapi_log_error.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-1/+1
| | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11812 DEADCODE Triaged Unassigned Bug Moderate Fix Required repl_objset_destroy() ds/ldap/servers/plugins/replication/repl_objset.c Comment: Fixed a typo. The line 182 is supposed to be: 182 if ((co = llistGetFirst((*o)->objects, &cookie)) != NULL)
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-5/+0
| | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11811 DEADCODE Triaged Unassigned Bug Minor Fix Required decode_total_update_extop() ds/ldap/servers/plugins/replication/repl5_total.c Comment: dn_csn is declared and initialized, but not really used. We are removing these lines: 710 CSN *dn_csn = NULL; 816 if (NULL != dn_csn) 817 { Execution cannot reach this statement "csn_free(&dn_csn);". 818 csn_free(&dn_csn); 819 }
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-3/+3
| | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11809 DEADCODE Triaged Unassigned Bug Minor Ignore _replica_reap_tombstones() ds/ldap/servers/plugins/replication/repl5_replica.c Comment: If replica_name is NULL, _replica_reap_tombstones has returned at the line 2460. Thus there is no need to check "replica_name" is NULL or not at line 2555. 11810 DEADCODE Triaged Unassigned Bug Moderate Fix Required replica_check_for_data_reload() ds/ldap/servers/plugins/replication/repl5_replica.c Comment: At the line 1478, !cl_cover_be is always true. Therefore, there is no possibility that "<" is chosen in slapi_log_error.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-11/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11808 DEADCODE Triaged Unassigned Bug Minor Fix Required replication_multimaster_plugin_init() ds/ldap/servers/plugins/replication/repl5_init.c Comment: There used to be an initializing replica hash code between the line 573 and 575: 572 /* initialize replica hash - has to be done before mapping tree is 573 initialized so we can't do it in the start function */ 575 if (rc != 0) 576 { Execution cannot reach this statement "slapi_log_error(0, repl_plu...". 577 slapi_log_error(SLAPI_LOG_FATAL, repl_plugin_name, 578 "replication_multimaster_plugin_init: failed to initialize replica hash\n"); 579 return -1; 580 } The initializing replica hash code was moved out but the comment and the result checking code were left. Removing them. Also, setting non 0 value to a static int variable multimaster_initialised if the plugin registration was successful.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-22/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11806 DEADCODE Triaged Unassigned Bug Moderate Fix Required agmt_set_last_init_status() ds/ldap/servers/plugins/replication/repl5_agmt.c Comment: macro NSDS50_REPL_REPLICA_READY is 0 repl5.h:#define NSDS50_REPL_REPLICA_READY 0x00 /* Replica ready, go ahead */ Because of this if expression: 1991 else if (replrc != 0) "Replica acquired successfully" never be set to last_init_status. Removed (replrc == NSDS50_REPL_REPLICA_READY) checking from the else if (replrc != 0) clause and added "Replica acquired successfully" to the string to print message since replrc == NSDS50_REPL_REPLICA_READY there. 11807 DEADCODE Triaged Unassigned Bug Moderate Fix Required agmt_set_last_update_status() ds/ldap/servers/plugins/replication/repl5_agmt.c Comment: macro NSDS50_REPL_REPLICA_READY is 0 repl5.h:#define NSDS50_REPL_REPLICA_READY 0x00 /* Replica ready, go ahead */ Because of this if expression: 1991 else if (replrc != 0) "Replica acquired successfully" never be set to last_update_status. Removed (replrc == NSDS50_REPL_REPLICA_READY) checking from the else if (replrc != 0) clause and added "Replica acquired successfully" to the string to print message since replrc == NSDS50_REPL_REPLICA_READY there.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-3/+4
| | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11805 DEADCODE Triaged Unassigned Bug Minor Ignore clcache_load_buffer_bulk() ds/ldap/servers/plugins/replication/cl5_clcache.c Comment: Experimented the transaction control, but it was not adopted. 383 /* txn control seems not improving anything so turn it off */ Comment out these lines. 418 if ( txn ) { Execution cannot reach this statement "(*txn->commit)(txn, 256U);". 419 txn->commit ( txn, DB_TXN_NOSYNC ); 420 }
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-24/+9
| | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11803 DEADCODE Triaged Unassigned Bug Minor Fix Required _cl5GetFirstEntry() ds/ldap/servers/plugins/replication/cl5_api.c 11804 DEADCODE Triaged Unassigned Bug Minor Fix Required _cl5GetNextEntry() ds/ldap/servers/plugins/replication/cl5_api.c Comment: Eliminated unnecessary codes.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-4/+2
| | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11802 DEADCODE Triaged Unassigned Bug Minor Ignore dna_get_next_value() ds/ldap/servers/plugins/dna/dna.c Comment: Merged 2 pblock destroy codes slapi_pblock_destroy(pb) to one at the end of the function dna_get_next_value.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-5/+0
| | | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11800 DEADCODE Triaged Unassigned Bug Minor Fix Required cos_cache_add_defn() ds/ldap/servers/plugins/cos/cos_cache.c Comment: If theDef points to the allocated memory at the line 1410, ret never becomes -1. Thus, theDef never be non-NULL at 1497. Removing 1497 if(theDef) 1498 slapi_ch_free((void**)&theDef); 11801 DEADCODE Triaged Unassigned Bug Minor Fix Required cos_cache_follow_pointer() ds/ldap/servers/plugins/cos/cos_cache.c Comment: default is not needed: 3525 default: 3526 goto bail;
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-1/+1
| | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11798 DEADCODE Triaged Unassigned Bug Moderate Fix Required cb_sasl_bind_once_s() ds/ldap/servers/plugins/chainingdb/cb_bind.c Comment: This is not a DEADCODE problem, but a half-baked implementation considering this comment: 190 /* realloc matcheddn & errmsg because the mem alloc model */ 191 /* may differ from malloc The author intended this: 184 rc = ldap_parse_result( ld, result, status, &matcheddnp2, &errmsgp2, 185 &referrals, resctrlsp, 1 );
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11796 DEADCODE Triaged Unassigned Bug Minor Ignore slapi_ldap_init_ext() ds/ldap/servers/slapd/ldaputil.c Comment: ldapurl is guaranteed not NULL. 323 slapi_log_error(SLAPI_LOG_FATAL, "slapi_ldap_init_ext", 324 "Could not parse given LDAP URL [%s] : error [%s]\n", 325 ldapurl ? ldapurl : "NULL", 326 slapi_urlparse_err2string(rc)); 11797 DEADCODE Triaged Unassigned Bug Minor Ignore slapi_ldap_bind() ds/ldap/servers/slapd/ldaputil.c Comment: It is guaranteed that mech has some value at the line 755. 755 slapi_log_error(SLAPI_LOG_FATAL, "slapi_ldap_bind", 756 "Error: could not perform interactive bind for id " 757 "[%s] mech [%s]: error %d (%s)\n", 758 bindid ? bindid : "(anon)", 759 mech ? mech : "SIMPLE", 760 rc, ldap_err2string(rc));
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-9/+3
| | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11795 DEADCODE Triaged Unassigned Bug Minor Fix Required DS_LASRoleDnAttrEval() ds/ldap/servers/plugins/acl/acllas.c Comment: Merged the 2 lines to check matched with ACL_TRUE into one.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-1/+1
| | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11794 DEADCODE Triaged Unassigned Bug Minor Ignore slapi_dn_syntax_check() ds/ldap/servers/slapd/plugin_syntax.c Comment: Checking for the possibility of dn == NULL is not needed since it is already checked at the line 303.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-1/+1
| | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11792 DEADCODE Triaged Unassigned Bug Minor Fix Required acl__match_handlesFromCache() ds/ldap/servers/plugins/acl/acl.c Comment: Looks like a simple copy & paste bug. Replaced the macro to compare ACLPB_HAS_ACLCB_EVALCONTEXT with ACLPB_EVALCONTEXT_ACLCB.
* Bug 617013 - repl-monitor.pl use cpu upto 90%Rich Megginson2010-07-221-1/+2
| | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617013 Resolves: bug 617013 Bug Description: repl-monitor.pl use cpu upto 90% Reviewed by: nhosoi (Thanks!) Branch: master Fix Description: The script recursively looks for servers - looks at servers in replication agreements, adds them, then looks for replication agreements on those servers, etc. When it added the servers, the logic was faulty for seeing if the server was already in the list. So it just kept recursing forever. One of the problems was that the script did not like a hostname with a non \w char in it, such as the "-" char. There was another problem with matching a server without a shadowport. Platforms tested: RHEL5 x86_64 Flag Day: no Doc impact: no (cherry picked from commit 7de9007936a790625258967bfb959bc5989d25f2)
generated by cgit (git 2.34.1) at 2025-09-26 21:13:38 +0000