summaryrefslogtreecommitdiffstats
path: root/ldap/servers
Commit message (Collapse)AuthorAgeFilesLines
...
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+2
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11996. description: The str2entry_dupcheck() has been modified to release unused maxcsn.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+11
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11995. description: The str2entry_dupcheck() has been modified to release attributedeletioncsn properly.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-7/+13
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11994. description: The acl__malloc_aclpb() has been modified to release resources when an error occurs.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-22/+25
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11991. description: The acllas__client_match_URL() has been modified to set/allocate and release hostport only when it receives ldap(s)://host:port/ URL.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11986. description: The log__open_auditlogfile() has been modified to release log when an error occurs.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-1/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11984. description: The mtn_get_referral_from_entry() has been modified to avoid leaking the referral object.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-1/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11983. description: The pw_rever_encode() has been modified to release pwsp at the end of each loop iteration.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-1/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11982. description: The check_trivial_words() has been modified to check for NULL smods first before allocating smod to avoid resource leak.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11980. description: The log__open_accesslogfile() has been modified to release log when an error occurs.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11978. description: The slapi_register_object_extension() has been modified to release fe when an error occurs.
* Bug 614511 - fix coverity Defect Type: Null pointer dereferences issues ↵Noriko Hosoi2010-08-191-8/+7
| | | | | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 11856 Comment: If the aci "rule" does not include "($dn)", there is no pointer assigined to aci_macro and matched_val is NULL. In that case, acllas_replace_dn_macro is supposed to return just "user" itself regardless of [$dn].
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-21/+19
| | | | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in slapi_vattr_list_attrs(), slapi_vattrspi_regattr(), and vattr_map_entry_new(). Replaced PR_smprintf() and PR_smprintf_free() with slapi_ch_calloc() and slapi_ch_free().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-18/+51
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in slapi_pblock_get().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-1/+5
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in addlenstr().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-6/+3
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in repl_objset_destroy().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-3/+8
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in conn_push_schema().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-4/+9
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in _cl5PositionCursorForReplay().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-4/+10
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in linked_attrs_modrdn_post_op().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-1/+6
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in acl_operation_ext_destructor() and acl_init_aclpb().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-1/+5
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in filter_compute_hash().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-4/+10
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in slapi_dn_normalize_ext() and slapi_sdn_done().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-1/+1
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in decode_repl_ext_response().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-13/+11
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in ruv_covers_ruv() and get_ruvelement_from_berval().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-3/+6
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in _replica_reap_tombstones().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-2/+5
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in prot_thread_main().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-4/+12
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in memberof_get_groups_callback().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-5/+4
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in cos_cache_query_attr().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-15/+40
| | | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in cb_instance_free(), cb_instance_hosturl_set(), and cb_instance_starttls_set(), cb_instance_bindmech_set(), and cb_instance_config_get().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-3/+8
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in acl_access_allowed_main().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-3/+9
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in __acllist_add_aci() and acllist_aciscan_update_scan().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-2/+14
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in acllas__client_match_URL() and acllas__user_has_role().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-2/+7
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in aclg_get_usersGroup().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-5/+20
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in acl_access_allowed() and acl__TestRights().
* Bug 610281 - fix coverity Defect Type: Control flow issues - last repl init ↵Rich Megginson2010-08-181-1/+1
| | | | | | | | | | | | | | | | | status https://bugzilla.redhat.com/show_bug.cgi?id=610281 Resolves: bug 610281 Bug Description: fix coverity Defect Type: Control flow issues - last repl init status Reviewed by: one-line rule Branch: master Fix Description: agmt_set_last_init_status() is never called in order to set the status to "Replica acquired successfully". Adding that string to the message breaks tests that expect init success to report 0 Total update succeeded Platforms tested: RHEL5 x86_64, Fedora 14 x86_64 Flag Day: no Doc impact: no
* Bug 610281 - fix coverity Defect Type: Control flow issues - ↵Rich Megginson2010-08-161-6/+5
| | | | | | | | | | | | | | | | daemon.c:write_function() https://bugzilla.redhat.com/show_bug.cgi?id=610281 Resolves: bug 610281 Bug Description: fix coverity Defect Type: Control flow issues - daemon.c:write_function() Reviewed by: nhosoi (Thanks!) Branch: master Fix Description: sentbytes < count is ok in the non error case - it just means we need to send some more data. Move the checking to the error case so we can print the number of bytes sent and expected. Platforms tested: RHEL5 x86_64, Fedora 14 x86_64 Flag Day: no Doc impact: no
* Bug 623118 - Simplepaged results going in infinite loopNoriko Hosoi2010-08-111-0/+4
| | | | | | | | | | | if a sub suffix exists in the domain https://bugzilla.redhat.com/show_bug.cgi?id=623118 Description: When paging is done on a backend, and if there are more sub backends to be searched and paged, simple paged code is supposed to set the next backend to connection->c_current_be. The setting was missing.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-1/+1
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The "new_row" assignment on line 87 can be removed because it is not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-1/+1
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Pointer "slapdFrontendConfig" returned by "init_config" is never used (line 244).
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-2/+0
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Calling slapi_sdn_get_dn and assigning the return value to base is not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-4/+3
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The "p" assignments on line 260, 264, and 268 can be removed because they are not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-5/+0
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Pointer "log_dir" returned by "dblayer_get_home_dir" is never used (line 1492). Removing the unnecessary else clause.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-3/+2
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The "cn" assignment on line 221 can be removed because it is not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-2/+1
| | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Pointer "replica" returned by "object_get_data(prp->replica_object)" (line 502) is never used. In "case STATE_READY_TO_ACQUIRE", Replica object "replica" is not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-3/+1
| | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The return value from object_get_data is assigend to ruv just to check if repl_ruv object exists or not with PR_ASSERT in the DEBUG mode (line 218). Passing the object_get_data call to PR_ASSERT directly.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-3/+2
| | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Pointer "replica" returned by "object_get_data(prp->replica_object)" (line 826) is never used. In "case STATE_READY_TO_ACQUIRE", Replica object "replica" is not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-1/+1
| | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The "bval" assignment on line 636 can be removed because any value is accepted. Note: This is to set debug mode "cb_set_debug(1)" which is enabled by having nsDebug in the chaining config entry.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-6/+6
| | | | | | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The "ptr" assignment on line 2622 is unnecessary because the value is never used. The "word" assignment on line 2630 can be removed because the first token is ignored. Alternatively the value should be validated. The "ptr" assignment on line 1456 is unnecessary because the value is not used. The "word" assignment on line 1463 can be removed because the first token is ignored. Alternatively the value should be validated. The "ptr" assignment on line 1210 is unnecessary because the value is never used. The "word" assignment on line 1217 can be removed because the first token is ignored. Alternatively the value should be validated.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-6/+6
| | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The "word" assignment on line 961 and 963 is unnecessary because the value will be overwritten. Comment: The "s" assignments on line 271, 280, and 281 are unnecessary because the value is never used.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-2/+0
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The call to strchr() is unnecessary because strcpy() will ensure that string p is NULL-terminated.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-1/+1
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The str assignment on line 1240 can be removed because the value is not needed or will be overwritten.