diff options
| author | Nathan Kinder <nkinder@redhat.com> | 2010-09-14 11:00:59 -0700 |
|---|---|---|
| committer | Nathan Kinder <nkinder@redhat.com> | 2010-09-15 09:11:05 -0700 |
| commit | b28a60185cd54f149e77a1f34ffbfd676f5f2342 (patch) | |
| tree | 1992c3031f08fe1cb4a429774d2805bbc27e88c2 | |
| parent | a250d242395d089e7e8a2b2a3d07394eaa49d4d4 (diff) | |
| download | ds-b28a60185cd54f149e77a1f34ffbfd676f5f2342.tar.gz ds-b28a60185cd54f149e77a1f34ffbfd676f5f2342.tar.xz ds-b28a60185cd54f149e77a1f34ffbfd676f5f2342.zip | |
Bug 630097 - (cov#15461) Remove unnecessary NULL check in DNA
It is not necessary to check if config_entry->types is NULL since
it is guaranteed to be non-NULL by dna_parse_config_entry() when
it creates config_entry. Coverity thinks that a NULL derefence is
possible since we are checking if config_entry->types is NULL. We
should remove this NULL check.
| -rw-r--r-- | ldap/servers/plugins/dna/dna.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ldap/servers/plugins/dna/dna.c b/ldap/servers/plugins/dna/dna.c index 837b674c..e60f3714 100644 --- a/ldap/servers/plugins/dna/dna.c +++ b/ldap/servers/plugins/dna/dna.c @@ -2861,7 +2861,7 @@ static int dna_pre_op(Slapi_PBlock * pb, int modtype) if (LDAP_CHANGETYPE_ADD == modtype) { - if (config_entry->types && dna_is_multitype_range(config_entry)) { + if (dna_is_multitype_range(config_entry)) { /* For a multi-type range, we only generate a value * for types where the magic value is set. We do not * generate a value for missing types. */ |