ds.git/lib/libaccess, branch 573889

Bug 630091 - (cov#11973) Array overrun in libaccess

2010-09-24T17:04:12+00:00

When going through the exceptions table in libaccess, we don't
check if we are at the last pair of elements in the array before
incrementing to the next pair.  This patch adds checks to see if
we are at the last pair of elements and avoids the increment if
necessary.

Bug 630092 - Coverity #11992,11993: Resource leaks issues

2010-09-20T15:15:01+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=630092

Description:

The acl_Parse() has been modified to release newacls and newaclv
when an error occurs.

Bug 630091 - (cov#12209) Use of uninitialized pointer in libaccess

2010-09-15T21:58:53+00:00

It looks like aclpvt is only initialized before use if __cplusplus
or lint are defined.  I see no harm in always initializing aclpvt
to NULL, which will guarantee that we don't use an uninitialized
pointer.

Bug 630097 - (cov#11964) Remove dead code from libaccess

2010-09-15T16:11:05+00:00

The libaccess library has some dead functions it it.  One of these
functions was flagged as having a NULL pointer dereference issue
by Coverity.  The problem function is unused, so it should be removed.
There are also a number of other unused functions in the same source
file that should be removed.

Bug 690090 - (cov#11974) Remove additional unused ACL functions

2010-09-09T22:04:53+00:00

There are a few more unused ACL functions to remove.  One of these
unused functions is causing coverity to report an error about
memory corruption.

Bug 630090 - (cov#11974) Remove unused ACL functions

2010-09-09T17:18:59+00:00

Coverity flagged a memory corruption issue in an old unused
ACL function.  It is best to just remove these unused functions.
The functions removed are:

  ACL_ParseFile
  ACL_WriteFile
  ACL_WriteString
  ACL_Decompose
  acl_to_str_*
  acl_decompose_*

fix compiler warnings - unused vars/funcs, invalid casts

2010-09-01T23:08:30+00:00

This commit fixes many compiler warnings, mostly for things like unused
variables, functions, goto labels.
One place was using csngen_free instead of csn_free.  A couple of places
were using casts incorrectly, and several places needed some casts added.
Tested on: RHEL5 x86_64, Fedora 14 x86_64
Reviewed by: nkinder (Thanks!)

Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166

2010-08-23T23:38:53+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=611790
Resolves: bug 611790
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Fix description: Use the right pointer in LASIpAddPattern().
coverity ID: 11945

Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199

2010-08-23T18:07:37+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=610119
Resolves: bug 610119
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Fix description: Catch possible NULL pointer in acl_usr_cache_insert().

Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199

2010-08-23T18:07:31+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=610119
Resolves: bug 610119
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Fix description: Catch possible NULL pointer in LASDnsBuild().