1 files changed, 59 insertions, 0 deletions
diff --git a/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/AssignmentInConditionChecker.java b/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/AssignmentInConditionChecker.java
new file mode 100644
index 0000000..6a17ef8
--- /dev/null
+++ b/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/AssignmentInConditionChecker.java
@@ -0,0 +1,59 @@
+/*******************************************************************************
+ * Copyright (c) 2009, 2010 Alena Laskavaia 
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *    Alena Laskavaia  - initial API and implementation
+ *******************************************************************************/
+package org.eclipse.cdt.codan.internal.checkers;
+
+import org.eclipse.cdt.codan.core.cxx.model.AbstractIndexAstChecker;
+import org.eclipse.cdt.core.dom.ast.ASTNodeProperty;
+import org.eclipse.cdt.core.dom.ast.ASTVisitor;
+import org.eclipse.cdt.core.dom.ast.IASTBinaryExpression;
+import org.eclipse.cdt.core.dom.ast.IASTExpression;
+import org.eclipse.cdt.core.dom.ast.IASTForStatement;
+import org.eclipse.cdt.core.dom.ast.IASTIfStatement;
+import org.eclipse.cdt.core.dom.ast.IASTTranslationUnit;
+
+public class AssignmentInConditionChecker extends AbstractIndexAstChecker {
+	private static final String ER_ID = "org.eclipse.cdt.codan.internal.checkers.AssignmentInConditionProblem"; //$NON-NLS-1$
+
+	public void processAst(IASTTranslationUnit ast) {
+		// traverse the ast using the visitor pattern.
+		ast.accept(new CheckCodeVisitor());
+	}
+
+	class CheckCodeVisitor extends ASTVisitor {
+		CheckCodeVisitor() {
+			shouldVisitExpressions = true;
+		}
+
+		public int visit(IASTExpression expression) {
+			if (isAssignmentExpression(expression)
+					&& isUsedAsCondition(expression)) {
+				reportProblem(ER_ID, expression, expression.getRawSignature());
+			}
+			return PROCESS_CONTINUE;
+		}
+
+		private boolean isAssignmentExpression(IASTExpression e) {
+			if (e instanceof IASTBinaryExpression) {
+				IASTBinaryExpression binExpr = (IASTBinaryExpression) e;
+				return binExpr.getOperator() == IASTBinaryExpression.op_assign;
+			}
+			return false;
+		}
+
+		private boolean isUsedAsCondition(IASTExpression expression) {
+			ASTNodeProperty prop = expression.getPropertyInParent();
+			if (prop == IASTForStatement.CONDITION
+					|| prop == IASTIfStatement.CONDITION)
+				return true;
+			return false;
+		}
+	}
+}