From 4880739c17b502d00a9ec45c6f6dd3e8bbff057f Mon Sep 17 00:00:00 2001 From: David Sommerseth Date: Thu, 18 Feb 2010 21:20:14 +0100 Subject: Do not randomize resolving of IP addresses in getaddr() Based on a discussion on the mailing list and in the IRC meeting Feb 18, it was decided to remove get_random() from the getaddr() function as that can conflict with round-robin/randomization done by DNS servers. This change must be documented in the release notes. Signed-off-by: David Sommerseth --- socket.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'socket.c') diff --git a/socket.c b/socket.c index fecc398..e42ccb9 100644 --- a/socket.c +++ b/socket.c @@ -212,12 +212,11 @@ getaddr (unsigned int flags, ++n; ASSERT (n >= 2); - msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to %d addresses, choosing one by random", + msg (D_RESOLVE_ERRORS, "RESOLVE: NOTE: %s resolves to %d addresses, choosing the first resolved IP address", hostname, n); - /* choose address randomly, for basic load-balancing capability */ - ia.s_addr = *(in_addr_t *) (h->h_addr_list[get_random () % n]); + ia.s_addr = *(in_addr_t *) (h->h_addr_list[0]); } } -- cgit