diff options
| author | Gert Doering <gert@greenie.muc.de> | 2012-06-30 22:50:43 +0200 |
|---|---|---|
| committer | David Sommerseth <dazo@users.sourceforge.net> | 2012-07-02 09:31:42 +0200 |
| commit | 8df08de6f84d224c6a79ab6c74ba73c33a47735d (patch) | |
| tree | e0915d4f669b6fa5d5961051116312e28e197072 | |
| parent | dc73460093d59cdc6549edf503f43e14ea33aef0 (diff) | |
| download | openvpn-8df08de6f84d224c6a79ab6c74ba73c33a47735d.tar.gz openvpn-8df08de6f84d224c6a79ab6c74ba73c33a47735d.tar.xz openvpn-8df08de6f84d224c6a79ab6c74ba73c33a47735d.zip | |
Repair "tap server" mode brokenness caused by <stdbool.h> fallout
Operator/Cast precedence wrong: casting mac[0] to (bool) first - giving
"1" for "any mac address that does not start with 00:" - and only then
bit-anding with "1" - thus always returning "true". Which, in turn,
leads to "reject all incoming packets with 'bad source address'".
OpenVPN bug #216.
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Fabian Knittel <fabian.knittel@lettink.de>
Message-Id: 1341089443-2287-1-git-send-email-gert@greenie.muc.de
URL: http://article.gmane.org/gmane.network.openvpn.devel/6817
Signed-off-by: David Sommerseth <dazo@users.sourceforge.net>
| -rw-r--r-- | src/openvpn/mroute.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/openvpn/mroute.c b/src/openvpn/mroute.c index aecb702..850e336 100644 --- a/src/openvpn/mroute.c +++ b/src/openvpn/mroute.c @@ -52,7 +52,7 @@ mroute_addr_init (struct mroute_addr *addr) static inline bool is_mac_mcast_addr (const uint8_t *mac) { - return (bool) mac[0] & 1; + return (bool) (mac[0] & 1); } static inline bool |