summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid Sommerseth <davids@redhat.com>2010-12-13 12:49:00 +0100
committerDavid Sommerseth <davids@redhat.com>2011-03-24 19:50:00 +0100
commit527a351d5843793d016735a5e24daab42442ba45 (patch)
tree318a660a5f32c4c55bdd5bc6b533e9eb00fb67ae
parentef2cbc771a6cf95868f2bb1c692e3cc9e2be5280 (diff)
downloadopenvpn-527a351d5843793d016735a5e24daab42442ba45.zip
openvpn-527a351d5843793d016735a5e24daab42442ba45.tar.gz
openvpn-527a351d5843793d016735a5e24daab42442ba45.tar.xz
Open log files as text files on Windows
By giving the "t" flag to _fdopen() on Windows, the file will be opened in a "translate mode", where it will take care of converting \n to \r\n, and also look for the CTRL-Z mark when opening the log file in append mode. Reference: <http://msdn.microsoft.com/en-us/library/dye30d82%28VS.80%29.aspx> Thanks to Alon Bar-Lev for pointing out this solution. Reported-by: Thomas Reifferscheid Signed-off-by: David Sommerseth <davids@redhat.com> Acked-by: Gert Doering <gert@greenie.muc.de>
-rw-r--r--error.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/error.c b/error.c
index 5c53251..9754464 100644
--- a/error.c
+++ b/error.c
@@ -506,7 +506,7 @@ redirect_stdout_stderr (const char *file, bool append)
/* open log_handle as FILE stream */
ASSERT (msgfp == NULL);
- msgfp = _fdopen (log_fd, "w");
+ msgfp = _fdopen (log_fd, "wt");
if (msgfp == NULL)
msg (M_ERR, "Error: --log redirect failed due to _fdopen");