openvpn.git/src/openvpn/push.c, branch release/2.3

Fix spurious ignoring of pushed config options (trac#349).

2014-01-07T21:16:50+00:00

The function incoming_push_message(...) in push.c uses a local variable
option_types_found, that gets passed to do_up(...).

If the server push got split into several parts, only the last part
(PUSH_MSG_REPLY) option_types_found is used for do_up (initilized as 0
locally), the previous ones (PUSH_MSG_CONTINUATION) are ignored.

So e.g. a ping config, pushed by the server in the first push, followed
by a lot of "push route" configs, causing a second push message, will
have the do_up() called, but without e.g. the OPT_P_TIMER flag, so those
options will be silently ignored.

The patch resolves that, by introducing "push_option_types_found" in
"c->options" and using that as storage.

Fix trac bug #349.

Acked-by: Gert Doering 
URL: https://community.openvpn.net/openvpn/ticket/349
Signed-off-by: Gert Doering 
(cherry picked from commit 1aac9a0b7a4046822a0134cd8693a828f2e16576)

Fix client crash on double PUSH_REPLY.

2013-01-02T12:20:50+00:00

Introduce an extra bool variable c2.pulled_options_md5_init_done to
keep track of md5_init state of pulled_options_state - avoid accessing
uninitialized state when a second PUSH_REPLY comes in (which only happens
under very particular circumstances).

Bug tracked down by Arne Schwabe .

Signed-off-by: Gert Doering 
Acked-by: Arne Schwabe 
Message-Id: 20121225124856.GT22465@greenie.muc.de
URL: http://article.gmane.org/gmane.network.openvpn.devel/7216
Signed-off-by: David Sommerseth 
(cherry picked from commit 1978db4b9657f0db134f1deaeb1e8400bf6a033e)

Fix reconnect issues when --push and UDP is used on the server

2012-09-11T17:01:14+00:00

When the server is configured with UDP and --push statements, reconnecting
often fails by the client never receiving PUSH_REPLY.  The client sends
PUSH_REQUEST and the server logs these requests but does not send them.

This bug got introduced in commit ff65da3a230b658b2c1d52dc1a48612e80a2eb42
which tries to avoid sending duplicated PUSH messages if the client/server
connection is slow.

This patch keeps this behaviour, but instead of a session wide PUSH_REPLY
block it sets an expiry time for the PUSH_REPLY block.  The expiry time
is set to 30 seconds.

Signed-off-by: David Sommerseth 
Cc: James Yonan 
Acked-by: Gert Doering 
Acked-by: James Yonan 
Message-Id: 1347154246-20143-1-git-send-email-dazo@users.sourceforge.net
URL: http://article.gmane.org/gmane.network.openvpn.devel/7044

build: move out config.h include from syshead

2012-03-22T21:53:39+00:00

Yet another step in reducing the syshead.h content.

Conditional compilation of sources needs to be based on
a minimum program prefix (config.h only).

Signed-off-by: Alon Bar-Lev 
Acked-by: David Sommerseth 
Signed-off-by: David Sommerseth

build: standard directory layout

2012-03-22T21:07:08+00:00

Suitable for mature project.

root   - administrative stuff
doc    - documents
src    - sources
tests  - tests
distro - distro specific files
sample - samples

SIDE EFFECT: many changes to rpm spec.

Signed-off-by: Alon Bar-Lev 
Acked-by: Adriaan de Jong 
Signed-off-by: David Sommerseth