From cb01e059cd106143137e9531978b5e157234a557 Mon Sep 17 00:00:00 2001 From: "Gustavo J. A. M. Carneiro" Date: Sat, 14 Jan 2006 17:51:47 +0000 Subject: Warn if io callback returns None: almost always this is an error --- ChangeLog | 5 +++++ gobject/gobjectmodule.c | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/ChangeLog b/ChangeLog index a329971..29a2886 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2006-01-14 Gustavo J. A. M. Carneiro + + * gobject/gobjectmodule.c (iowatch_marshal): Warn if io callback + returns None: almost always this is an error. + 2006-01-13 Gustavo J. A. M. Carneiro * gobject/pygobject.c (pygobject_register_class): Change strategy diff --git a/gobject/gobjectmodule.c b/gobject/gobjectmodule.c index 6e00ceb..37d2e4c 100644 --- a/gobject/gobjectmodule.c +++ b/gobject/gobjectmodule.c @@ -1921,6 +1921,12 @@ iowatch_marshal(GIOChannel *source, GIOCondition condition, gpointer user_data) PyErr_Print(); res = FALSE; } else { + if (ret == Py_None) { + if (PyErr_Warn(PyExc_Warning, "gobject.io_add_watch callback returned None;" + " should return True/False")) { + PyErr_Print(); + } + } res = PyObject_IsTrue(ret); Py_DECREF(ret); } -- cgit