From 5b28bd56725371d4a72988d4e72bb2fd852c6fa7 Mon Sep 17 00:00:00 2001 From: Neil Brown Date: Mon, 21 May 2007 14:25:47 +1000 Subject: Improve error message for adding bitmap to a level that cannot support it. Also give error on --build if no devices given. --- Create.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'Create.c') diff --git a/Create.c b/Create.c index 21e578b..2a4335a 100644 --- a/Create.c +++ b/Create.c @@ -87,11 +87,6 @@ int Create(struct supertype *st, char *mddev, int mdfd, Name ": a RAID level is needed to create an array.\n"); return 1; } - if (raiddisks < 1) { - fprintf(stderr, - Name ": a number of --raid-devices must be given to create an array\n"); - return 1; - } if (raiddisks < 4 && level == 6) { fprintf(stderr, Name ": at least 4 raid-devices needed for level 6\n"); @@ -115,6 +110,11 @@ int Create(struct supertype *st, char *mddev, int mdfd, fprintf(stderr, Name ": You haven't given enough devices (real or missing) to create this array\n"); return 1; } + if (bitmap_file && level <= 0) { + fprintf(stderr, Name ": bitmaps not meaningful with level %s\n", + map_num(pers, level)?:"given"); + return 1; + } /* now set some defaults */ if (layout == UnSet) -- cgit