diff options
author | Neil Brown <neilb@suse.de> | 2008-07-12 20:28:33 +1000 |
---|---|---|
committer | Neil Brown <neilb@suse.de> | 2008-07-12 20:28:33 +1000 |
commit | 6416d5275d65be25a6cd63583bb2b92e6fba95a5 (patch) | |
tree | 23757b31666774c05c405dfd720dc92b3bb03b90 /util.c | |
parent | 908ef18519f7d5780ebf00b19b913f8282eb4175 (diff) | |
download | mdadm-6416d5275d65be25a6cd63583bb2b92e6fba95a5.tar.gz mdadm-6416d5275d65be25a6cd63583bb2b92e6fba95a5.tar.xz mdadm-6416d5275d65be25a6cd63583bb2b92e6fba95a5.zip |
Use O_DIRECT for all IO to devices.
Using buffered IO risks non-atomic updates to parts of the
device that we don't actually want to write to. This isn't in
general safe.
So switch to O_DIRECT for all that IO and make sure we have
properly aligned buffers.
Diffstat (limited to 'util.c')
-rw-r--r-- | util.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -761,11 +761,11 @@ int dev_open(char *dev, int flags) snprintf(devname, sizeof(devname), "/dev/.tmp.md.%d:%d:%d", (int)getpid(), major, minor); if (mknod(devname, S_IFBLK|0600, makedev(major, minor))==0) { - fd = open(devname, flags); + fd = open(devname, flags|O_DIRECT); unlink(devname); } } else - fd = open(dev, flags); + fd = open(dev, flags|O_DIRECT); return fd; } |