summaryrefslogtreecommitdiffstats
path: root/Incremental.c
diff options
context:
space:
mode:
authorNeil Brown <neilb@suse.de>2008-05-27 09:18:32 +1000
committerNeil Brown <neilb@suse.de>2008-05-27 09:18:32 +1000
commit2318b9f0dc98b03d3e3374e41b2ca6f85b18f922 (patch)
tree6726127a79b25ae40749067d21cbbde81544d7a7 /Incremental.c
parent30e1b9a585ea667a3d79edd4e4ca2bf5692c2ab9 (diff)
downloadmdadm-2318b9f0dc98b03d3e3374e41b2ca6f85b18f922.tar.gz
mdadm-2318b9f0dc98b03d3e3374e41b2ca6f85b18f922.tar.xz
mdadm-2318b9f0dc98b03d3e3374e41b2ca6f85b18f922.zip
Remove 'fd' arg from sysfs_add_disk
It it never used, and removing means there are several 'open's that can go.
Diffstat (limited to 'Incremental.c')
-rw-r--r--Incremental.c10
1 files changed, 3 insertions, 7 deletions
diff --git a/Incremental.c b/Incremental.c
index 04e2e15..2c03a14 100644
--- a/Incremental.c
+++ b/Incremental.c
@@ -793,14 +793,10 @@ int Incremental_container(struct supertype *st, char *devname, int verbose,
sysfs_set_str(sra, NULL, "metadata_version", ver);
sysfs_set_array(sra, ra);
- for (dev = ra->devs; dev; dev = dev->next) {
- char buf[20];
- int dfd;
- sprintf(buf, "%d:%d", dev->disk.major, dev->disk.minor);
- dfd = dev_open(buf, O_RDONLY);
- if (sysfs_add_disk(sra, dfd, dev) == 0)
+ for (dev = ra->devs; dev; dev = dev->next)
+ if (sysfs_add_disk(sra, dev) == 0)
working++;
- }
+
if (runstop > 0 || working >= ra->array.working_disks) {
switch(ra->array.level) {
case LEVEL_LINEAR: