diff options
author | Neil Brown <neilb@suse.de> | 2006-10-16 15:26:43 +1000 |
---|---|---|
committer | Neil Brown <neilb@suse.de> | 2006-10-16 15:26:43 +1000 |
commit | b39827de21032f5bda931242f232ec9c3cb7da98 (patch) | |
tree | 34ac5f630691562826561ce9ada12d1f3de16ebc | |
parent | 97a6748ce2fc70f35b599bd16b76d16a1e48bc0d (diff) | |
download | mdadm-b39827de21032f5bda931242f232ec9c3cb7da98.tar.gz mdadm-b39827de21032f5bda931242f232ec9c3cb7da98.tar.xz mdadm-b39827de21032f5bda931242f232ec9c3cb7da98.zip |
Reduce max bitmap size when bitmap is in a file.
To ensure kernel never needs to allocate more than 1 page contiguously.
-rw-r--r-- | ChangeLog | 3 | ||||
-rw-r--r-- | bitmap.c | 7 |
2 files changed, 7 insertions, 3 deletions
@@ -1,6 +1,9 @@ Changes Prior to this release - Don't #include linux/blkpg.h as that isn't safe. Just include the content literally. + - Reduce maximum bitmap usage when working with bitmap files, + so that a only single-page allocations are made, even on + 64bit hosts with 4K pages. Changes Prior to 2.5.4 release - When creating devices in /dev/md/ create matching symlinks @@ -345,11 +345,12 @@ int CreateBitmap(char *filename, int force, char uuid[16], if (chunksize == UnSet) { /* We don't want more than 2^21 chunks, as 2^11 fill up one * 4K page (2 bytes per chunk), and 2^10 address of those - * fill up a 4K indexing page. 2^20 might be safer... + * fill up a 4K indexing page. 2^20 might be safer, especially + * on 64bit hosts, so use that. */ chunksize = DEFAULT_BITMAP_CHUNK; - /* <<21 for 2^21 chunks, >>9 to convert bytes to sectors */ - while (array_size > (chunksize << (21-9))) + /* <<20 for 2^20 chunks, >>9 to convert bytes to sectors */ + while (array_size > (chunksize << (20-9))) chunksize <<= 1; } |