From b2c9179933763453a0f7848b136c12e5bd7ec0a9 Mon Sep 17 00:00:00 2001 From: Osier Yang Date: Mon, 7 May 2012 19:02:12 +0800 Subject: python: Fix the forward_null error in Python binding codes This patch resolves: https://bugzilla.redhat.com/show_bug.cgi?id=771021 (cherry picked from commit b80f4db9931ceea4bec1d178322058df77ece7a4) Related coverity log: Error: FORWARD_NULL: /builddir/build/BUILD/libvirt-0.9.10/python/libvirt-override.c:355: assign_zero: Assigning: "params" = 0. /builddir/build/BUILD/libvirt-0.9.10/python/libvirt-override.c:458: var_deref_model: Passing null variable "params" to function "getPyVirTypedParameter", which dereferences it. (The dereference is assumed on the basis of the 'nonnull' parameter attribute.) --- libvirt-override.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-override.c b/libvirt-override.c index d9dc1b5..ba5ac28 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -71,7 +71,7 @@ static char *py_str(PyObject *obj) /* Helper function to convert a virTypedParameter output array into a * Python dictionary for return to the user. Return NULL on failure, * after raising a python exception. */ -static PyObject * ATTRIBUTE_NONNULL(1) +static PyObject * getPyVirTypedParameter(const virTypedParameterPtr params, int nparams) { PyObject *key, *val, *info; -- cgit