From 12d8d49559c2c4616357dd1d99cd7bcd39646033 Mon Sep 17 00:00:00 2001
From: Cole Robinson <crobinso@redhat.com>
Date: Wed, 15 Jun 2011 20:02:27 -0400
Subject: python: events: Fix C->Python handle callback prototype

If registering our own event loop implementation written in python,
any handles or timeouts callbacks registered by libvirt C code must
be wrapped in a python function. There is some argument trickery that
makes this all work, by wrapping the user passed opaque value in
a tuple, along with the callback function.

Problem is, the current setup requires the user's event loop to know
about this trickery, rather than just treating the opaque value
as truly opaque.

Fix this in a backwards compatible manner, and adjust the example
python event loop to do things the proper way.
---
 libvirt-override.py | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

(limited to 'libvirt-override.py')

diff --git a/libvirt-override.py b/libvirt-override.py
index b611ca4..8df9dc1 100644
--- a/libvirt-override.py
+++ b/libvirt-override.py
@@ -117,19 +117,41 @@ def getVersion (name = None):
 #
 # Invoke an EventHandle callback
 #
-def eventInvokeHandleCallback (watch, fd, event, callback, opaque):
+def eventInvokeHandleCallback(watch, fd, event, opaque, opaquecompat=None):
     """
     Invoke the Event Impl Handle Callback in C
     """
+    # libvirt 0.9.2 and earlier required custom event loops to know
+    # that opaque=(cb, original_opaque) and pass the values individually
+    # to this wrapper. This should handle the back compat case, and make
+    # future invocations match the virEventHandleCallback prototype
+    if opaquecompat:
+        callback = opaque
+        opaque = opaquecompat
+    else:
+        callback = opaque[0]
+        opaque = opaque[1]
+
     libvirtmod.virEventInvokeHandleCallback(watch, fd, event, callback, opaque);
 
 #
 # Invoke an EventTimeout callback
 #
-def eventInvokeTimeoutCallback (timer, callback, opaque):
+def eventInvokeTimeoutCallback(timer, opaque, opaquecompat=None):
     """
     Invoke the Event Impl Timeout Callback in C
     """
+    # libvirt 0.9.2 and earlier required custom event loops to know
+    # that opaque=(cb, original_opaque) and pass the values individually
+    # to this wrapper. This should handle the back compat case, and make
+    # future invocations match the virEventTimeoutCallback prototype
+    if opaquecompat:
+        callback = opaque
+        opaque = opaquecompat
+    else:
+        callback = opaque[0]
+        opaque = opaque[1]
+
     libvirtmod.virEventInvokeTimeoutCallback(timer, callback, opaque);
 
 def _dispatchEventHandleCallback(watch, fd, events, cbData):
-- 
cgit