From c9378ecd737dac326b7a4ddc44a830f2dbe0e975 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Mon, 10 Sep 2012 16:45:53 +0100 Subject: Check against python None type when filling in auth parameters When deciding whether to provide an auth function callback in openAuth(), credcb was checked against NULL, when it really needs to be checked against Py_None Signed-off-by: Daniel P. Berrange --- libvirt-override.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'libvirt-override.c') diff --git a/libvirt-override.c b/libvirt-override.c index 768144a..bb1d881 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -1840,7 +1840,8 @@ libvirt_virConnectOpenAuth(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) { auth.credtype[i] = (int)PyLong_AsLong(val); } } - auth.cb = pycredcb ? virConnectCredCallbackWrapper : NULL; + if (pycredcb && pycredcb != Py_None) + auth.cb = virConnectCredCallbackWrapper; auth.cbdata = pyauth; LIBVIRT_BEGIN_ALLOW_THREADS; -- cgit