diff options
author | Eric Blake <eblake@redhat.com> | 2012-06-11 14:32:47 -0600 |
---|---|---|
committer | Cole Robinson <crobinso@redhat.com> | 2012-06-14 18:38:27 -0400 |
commit | 077cbbb583542b6fc872cc464457455724af39e7 (patch) | |
tree | 37fdb49490c52938b31a87d739912e1d8d696b38 /libvirt-override.c | |
parent | d55bf4d3e48a24871bd5a6a096543f3f7b7d491d (diff) | |
download | libvirt-python-split-077cbbb583542b6fc872cc464457455724af39e7.tar.gz libvirt-python-split-077cbbb583542b6fc872cc464457455724af39e7.tar.xz libvirt-python-split-077cbbb583542b6fc872cc464457455724af39e7.zip |
python: use simpler methods
* python/libvirt-override.c (libvirt_virDomainGetVcpus)
(libvirt_virDomainGetVcpuPinInfo): Use Py_XDECREF instead of
open-coding it.
(cherry picked from commit 8566618f65d983b31efb8efec13c25c6410b1718)
Diffstat (limited to 'libvirt-override.c')
-rw-r--r-- | libvirt-override.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/libvirt-override.c b/libvirt-override.c index 130e702..da5cb9a 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -1415,15 +1415,9 @@ libvirt_virDomainGetVcpus(PyObject *self ATTRIBUTE_UNUSED, cleanup: VIR_FREE(cpuinfo); VIR_FREE(cpumap); - /* NB, Py_DECREF is a badly defined macro, so we require - * braces here to avoid 'ambiguous else' warnings from - * the compiler. - * NB. this comment is true at of time of writing wrt to - * at least python2.5. - */ - if (pyretval) { Py_DECREF(pyretval); } - if (pycpuinfo) { Py_DECREF(pycpuinfo); } - if (pycpumap) { Py_DECREF(pycpumap); } + Py_XDECREF(pyretval); + Py_XDECREF(pycpuinfo); + Py_XDECREF(pycpumap); return VIR_PY_NONE; } @@ -1584,7 +1578,7 @@ libvirt_virDomainGetVcpuPinInfo(PyObject *self ATTRIBUTE_UNUSED, cleanup: VIR_FREE(cpumaps); - if (pycpumaps) { Py_DECREF(pycpumaps);} + Py_XDECREF(pycpumaps); return VIR_PY_NONE; } |