summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJim Meyering <meyering@redhat.com>2009-09-03 14:09:49 +0200
committerJim Meyering <meyering@redhat.com>2009-09-03 18:04:24 +0200
commit68e1394d4363414400cf815227fcd678cd86cca3 (patch)
treefb59c34ce78f94ff3209be30803a8998499096ae
parent11bca8e4d912f360926c29981b6faf9dba45bf86 (diff)
downloadlibvirt-python-split-68e1394d4363414400cf815227fcd678cd86cca3.tar.gz
libvirt-python-split-68e1394d4363414400cf815227fcd678cd86cca3.tar.xz
libvirt-python-split-68e1394d4363414400cf815227fcd678cd86cca3.zip
python: let libvirt_virConnectDomainEventCallback indicate success
* python/libvir.c (libvirt_virConnectDomainEventCallback): Return 0 when successful, rather than always returning -1. clang flagged this function for its dead-store of "ret=0". Once "ret" was set to 0, it was never used, and the function would always return -1.
-rw-r--r--libvir.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/libvir.c b/libvir.c
index e2c196a..0c00b80 100644
--- a/libvir.c
+++ b/libvir.c
@@ -4,7 +4,7 @@
* entry points where an automatically generated stub is
* unpractical
*
- * Copyright (C) 2005, 2007, 2008 Red Hat, Inc.
+ * Copyright (C) 2005, 2007-2009 Red Hat, Inc.
*
* Daniel Veillard <veillard@redhat.com>
*/
@@ -1812,7 +1812,7 @@ libvirt_virConnectDomainEventCallback(virConnectPtr conn ATTRIBUTE_UNUSED,
cleanup:
LIBVIRT_RELEASE_THREAD_STATE;
- return -1;
+ return ret;
}
static PyObject *