From 0809cd5f9356372c966b7df71a6fb09f6ff87073 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Wed, 31 Mar 2021 08:16:04 +0200 Subject: efi_loader: Uart device path missing break In the devicepath node to text conversion for Uart nodes a break statement is missing. Indicated by Coverity Scan CID 330038 Fixes: 62df6e9c9994 ("efi_loader: Uart device path") Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_device_path_to_text.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c index 43554cd771..675e80bcb8 100644 --- a/lib/efi_loader/efi_device_path_to_text.c +++ b/lib/efi_loader/efi_device_path_to_text.c @@ -126,8 +126,10 @@ static char *dp_msging(char *s, struct efi_device_path *dp) switch (uart->stop_bits) { case 2: s += sprintf(s, "1.5)"); + break; default: s += sprintf(s, "%d)", uart->stop_bits); + break; } break; } -- cgit From d084f20233b1ca1fe1330e1aedb614b2a0c59abf Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Wed, 31 Mar 2021 06:34:33 +0000 Subject: efi_loader: typo 'devide path' Fix a typo in helloworld.efi. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/helloworld.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/helloworld.c b/lib/efi_loader/helloworld.c index 5c8b7a96f9..3f215e2a46 100644 --- a/lib/efi_loader/helloworld.c +++ b/lib/efi_loader/helloworld.c @@ -181,7 +181,7 @@ efi_status_t EFIAPI efi_main(efi_handle_t handle, (void **)&device_path); if (ret != EFI_SUCCESS) { con_out->output_string - (con_out, L"Missing devide path for device handle\r\n"); + (con_out, L"Missing device path for device handle\r\n"); goto out; } con_out->output_string(con_out, L"Boot device: "); -- cgit