| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
|
|
|
| |
Get rid of the constant clrsetbits_le32(), instead prepare the whole
content of the register once and write it at the end of the function.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Get rid of the constant clrsetbits_le32(), instead prepare the whole
content of the register once and write it at the end of the function.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Get rid of the constant clrsetbits_le32(), instead prepare the whole
content of the register once and write it at the end of the function.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
|
|
| |
Get rid of the constant clrsetbits_le32(), instead prepare the whole
content of the register once and write it at the end of the function.
Merge set_sdr_dram_timing{1,2,3,4,lowpwr}() into single function
set_sdr_dram_timing() , since there's no point in keeping all this
stuff separate anymore.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
|
|
| |
Get rid of the constant clrsetbits_le32(), instead prepare the whole
content of the register once and write it at the end of the function.
The big plan here is to remove all the CONFIG_HPS_SDR_ macros, hide
them in QTS compatibility layer in board implementation and pass only
a small structure into the driver.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
| |
Remove all parameters of this function, since they are only constants
passed in from another function, so make them local. Also, rename the
function to get_errata_rows() as this is closer to what it does.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Clean up weird parenthesis and odd type casts from the function.
Fix comment style.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Use generic function instead of CPU-specific one.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Add kerneldoc.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Simplify the loop code, optimizing compiler can deal with this.
No functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Clean up the computation of c_loop, outer and inner variables.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Factor out (afi_clocks - 1) into a single place instead of having it
all around the function.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Fix data types, clean up comments a bit and fix coding style a bit.
No functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Add kerneldoc and perform a minor comment cleanup.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Minor coding style cleanup, add kerneldoc. No functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function is implementing the DDR calibration Stage 3 as
described in Altera EMI_RM 2015.05.04 . The main body of this
function is almost identical to Stage 1.3 (DQ/DQS centering)
for all but two flags -- use_read_test and update_fom. Convert
this function to call rw_mgr_mem_calibrate_dq_dqs_centering()
with the correct flags set to trim down the code duplication.
Moreover, reorder the remnants in the function a little and
convert the function to return either 0 or -EIO in case of
success and failure respectively, to match the common return
value convention.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Brief clean, add kerneldoc.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Add kerneldoc.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Clean up coding style, mostly broken multiline formatting strings
in debug output. Also clean up data types and constify where applicable.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Move code around to get rid of the forward declaration. No change
to the actual code.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Add kerneldoc.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Fix return values to match the common return value convention.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Zap the useless addr variable.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Factor out common code for searching best DM/DQS window.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Fix data types and constify where applicable, fix broken multiline
debug strings and fix comments. No functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Add kerneldoc, no functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
| |
Fix the return value of the function to match common convention
where 0 means success and negative means error. Fix the return
values in case of an error to use errno.h codes.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
|
| |
The read_group and write_group arguments are the same in all
cases when this function is invoked, just merge them into one
rw_group argument. Also, clean up the function argument data
types and constify them.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
|
| |
The search_stop_check() always resets the bit_chk to a new value,
so bit_chk will never survive between search_left_edge() and
search_right_edge() invocation. There is thus no need to pass
it into these functions, so make bit_chk local to them.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Perform minor reordering of the function to make the code more
organised, no functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
| |
Factor out center_dq_windows(), which is common code between
stage 2 and stage 3 of the calibration again and cater for
the minor differences.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
| |
Factor out the get_window_mid_index() for finding the best DQ
window centering. This is again code common to two stages, so
pull it out.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
|
|
| |
First of all, don't break strings in the debug_cond() calls across
multiple lines. Next, zap a couple of really odd casts in the code.
Finally, make i into a signed variable, so it is possible to avoid
constructs of the form:
for (i = FOO;; i--) { <code>; if (i == 0) break; }.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
|
| |
Factor out common code from search_left_edge() and search_right_edge()
which checks whether searching for the window edge should stop. The
code is almost identical, so pull it into separate function and cater
for the minor differences.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
|
| |
Factor out common code from rw_mgr_mem_calibrate_writes_center()
and rw_mgr_mem_calibrate_vfifo_center() for searching for the
left edge of the window. The code is almost identical, so pull
it into separate function and cater for the minor differences.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
|
| |
Factor out common code from rw_mgr_mem_calibrate_writes_center()
and rw_mgr_mem_calibrate_vfifo_center() for searching for the
right edge of the window. The code is almost identical, so pull
it into separate function and cater for the minor differences.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
|
| |
Reorder the content of the function a little and fix the comments
so they at least become full sentences. Constify function args.
Fix the return value to match the common convention of 0 meaning
success.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Make the function documentation into kerneldoc.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Clean up the inner loop a bit. No functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
| |
The C language has signed types, so make use of them. Fix this
obscene loop, which tries to do away with unsigned type, but
just makes the code more cryptic.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Clean up data types and constify where applicable. No function change.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Clean up the debug output handling at the end of the function
and factor out common function call from the condition.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
| |
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Add kerneldoc, no functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Fix the return value to match common conventions and propagate
this change through the code.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Fix the data types, constify where applicable.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
| |
Implement common sdr_find_phase_delay() function and convert all
places which use such code to this unified function. No functional
change to the code.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
| |
Clean up odd multiline loop, no functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
|
|
| |
If d != 0 after sdr_working_phase() finishes, the else branch
of the condition has no impact on anything at all, since work_end
was already set independently of the value of "d" . Zap this
useless code.
Signed-off-by: Marek Vasut <marex@denx.de>
|
| |
|
|
|
|
|
| |
Fix broken multiline debug strings, fix comments.
No functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
|
