u-boot.git/fs/fat, branch master

fs: fat: fix file_fat_detectfs()

2021-04-10T10:00:24+00:00

Up to now file_fat_detectfs() did not detect some interface types like
EFI, HOST, VIRTIO.

Avoid duplicate code by calling blk_get_if_type_name().

The interface type now will be shown in lower case to match all other use
cases.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass

fs: fat: remove trailing periods from long name

2021-02-03T10:41:02+00:00

The FAT32 File System Specification [1] requires leading and trailing
spaces as well as trailing periods of long names to be ignored.

[1]
    Microsoft Extensible Firmware Initiative
    FAT32 File System Specification
    Version 1.03, December 6, 2000
    Microsoft Corporation
    https://www.win.tue.nl/~aeb/linux/fs/fat/fatgen103.pdf

Signed-off-by: Heinrich Schuchardt

fs: fat: must not write directory '.' and '..'

2021-02-03T10:10:37+00:00

Directories or files called '.' or '..' cannot be created or written to
in any directory. Move the test to normalize_longname() to check this
early.

Signed-off-by: Heinrich Schuchardt

fs: fat: usage basename in file_fat_write_at, fat_mkdir

2021-02-03T08:52:51+00:00

This patch involves no functional change. It is just about code
readability.

Both in file_fat_write_at() and fat_mkdir() the incoming file or directory
path are split into two parts: the parent directory and the base name.

In file_fat_write_at() the value of the variable basename is assigned to
the filename parameter and afterwards the variable filename is used instead
of basename. It is more readable to use the variable basename and leave
filename unchanged.

In fat_mkdir() the base name variable is called directory. This is
confusing. Call it basename like in file_fat_write_at(). This allows to
rename parameter new_directory to directory in the implementation of
fat_mkdir() to match the function declaration.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass

fs: fat: remove superfluous assignments

2021-01-29T15:36:48+00:00

Do not assign a value to a variable if it is not used.

Signed-off-by: Heinrich Schuchardt

fs: fat: avoid out of bounds access warning

2021-01-29T15:36:48+00:00

When copying short name plus extension refer to the encapsulating structure
and not to the short name element.

Signed-off-by: Heinrich Schuchardt

fs: fat: structure for name and extension

2021-01-23T06:56:53+00:00

The short name and extension of FAT files are stored in adjacent fields of
the directory entry. For some operations like calculating a checksum or
copying both fields it is preferable to treat both as one structure.

Change the definition of the directory entry structure to include a
structure comprising the name and the extension field.

This resolves Coverity CID 316357, CID 316350, CID 316348.

Signed-off-by: Heinrich Schuchardt

fs: fat: consistent error handling for flush_dir()

2021-01-23T06:56:53+00:00

Provide function description for flush_dir().
Move all error messages for flush_dir() from the callers to the function.
Move mapping of errors to -EIO to the function.
Always check return value of flush_dir() (Coverity CID 316362).

In fat_unlink() return -EIO if flush_dirty_fat_buffer() fails.

Signed-off-by: Heinrich Schuchardt

fs/fat: implement fsuuid command

2020-12-31T13:32:27+00:00

The FAT file system does not have a UUID but a 4 byte volume ID.
Let the fsuuid command show it in XXXX-XXXX format.

Signed-off-by: Heinrich Schuchardt

fs: fat: eliminate DIRENTSPERBLOCK() macro

2020-12-31T13:32:02+00:00

The FAT filesystem implementation uses several marcros referring to a magic
variable name mydata which renders the code less readable. Eliminate one of
them which is only used for a debug() statement.

Use log_debug() instead of debug().

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass