u-boot.git/drivers/net/phy, branch master

net: phy: xilinx: Break while loop over ethernet phy

2021-04-29T08:05:56+00:00

The commit 6c993815bbea ("net: phy: xilinx: Be compatible with live OF
tree") change driver behavior to while loop which wasn't correct because
the driver was looping over again and again. The reason was that
ofnode_valid() is taking 0 as correct value.
Fix it by changing while loop to ofnode_for_each_subnode() which is only
loop over available nodes.

Fixes: 6c993815bbea ("net: phy: xilinx: Be compatible with live OF tree")
Signed-off-by: Michal Simek 
Reviewed-by: Bin Meng

net: phy: fixed: Support the old DT binding

2021-04-15T08:52:17+00:00

Update fixedphy_probe() to support the old DT binding.

Signed-off-by: Bin Meng 
Reviewed-by: Ramon Fried 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Priyanka Jain

net: phy: fixed: Add the missing ending newline

2021-04-15T08:52:17+00:00

The printf statement doesn't end with a newline. Add it.

Signed-off-by: Bin Meng 
Reviewed-by: Ramon Fried 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Priyanka Jain

net: phy: fixed: Make driver ops static

2021-04-15T08:52:17+00:00

The PHY driver ops should be made static.

Signed-off-by: Bin Meng 
Reviewed-by: Ramon Fried 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Priyanka Jain

net: phy: Simplify the logic of phy_connect_fixed()

2021-04-15T08:52:17+00:00

Simplify the logic of phy_connect_fixed() by using the new API
ofnode_phy_is_fixed_link(), which brings additional bonus of
supporting the old DT bindings.

Signed-off-by: Bin Meng 
Reviewed-by: Ramon Fried 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Priyanka Jain

net: phy: xilinx: Drop #ifdef CONFIG_DM_ETH around phy_connect_gmii2rgmii()

2021-04-15T08:52:17+00:00

At present phy_connect_gmii2rgmii() is implemented using a DM API
dev_of_offset() hence it cannot support a non-DM configuration.
Remove the non-DM version prototype of phy_connect_gmii2rgmii()
and make the driver depend on CONFIG_DM_ETH.

Signed-off-by: Bin Meng 
Acked-by: Michal Simek 
Reviewed-by: Ramon Fried 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Priyanka Jain

net: phy: xilinx: Be compatible with live OF tree

2021-04-15T08:52:17+00:00

Following the same updates that were done to the fixed phy driver,
use ofnode_ APIs instead of fdt_ APIs so that the Xilinx PHY driver
can support live DT.

Signed-off-by: Bin Meng 
Reviewed-by: Priyanka Jain

net: phy: fixed: Drop #ifdef CONFIG_DM_ETH around phy_connect_fixed

2021-04-15T08:52:17+00:00

In drivers/net/phy/Kconfig, CONFIG_PHY_FIXED already depends on
CONFIG_DM_ETH, so the function prototype definition when
CONFIG_DM_ETH=n does nothing, so it can be dropped. It is also
never reachable, since the whole function is already under #ifdef
CONFIG_PHY_FIXED (which again, as I said, depends on CONFIG_DM_ETH=y).

Signed-off-by: Vladimir Oltean 
Reviewed-by: Bin Meng 
Tested-by: Bin Meng 
Message-Id: <20210216224804.3355044-3-olteanv@gmail.com>
Signed-off-by: Bin Meng 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Priyanka Jain

net: phy: fixed: Be compatible with live OF tree

2021-04-15T08:52:17+00:00

On systems that use CONFIG_OF_LIVE, the "ofnode" type is defined
as const struct device_node *np, while on the flat DT systems it
is defined as a long of_offset into gd->fdt_blob.

It is desirable that the fixed PHY driver uses the higher-level
ofnode abstraction instead of parsing gd->fdt_blob directly,
because that enables it to work on live OF systems.

The fixed PHY driver has used a nasty hack since its introduction in
commit db40c1aa1c10 ("drivers/net/phy: add fixed-phy /
fixed-link support"),
which is to pass the long gd->fdt_blob offset inside int phydev->addr
(a value that normally holds the MDIO bus address at which the PHY
responds). Even ignoring the fact that the types were already
mismatched leading to a potential truncation (flat OF offset was
supposed to be a long and not an int), we really cannot extend this
hack any longer, because there's no way an int will hold the other
representation of ofnode, the struct device_node *np.

So we unfortunately need to do the right thing, which is to use the
framework introduced by Grygorii Strashko in
commit eef0b8a930d1 ("net: phy: add ofnode node to struct phy_device").
This will populate phydev->node for the fixed PHY.

Note that phydev->node will not be valid in the probe function, since
that is called synchronously from phy_device_create and we really have
no way of passing the ofnode directly through the phy_device_create API.
So we do what other drivers do too: we move the OF parsing logic from
the .probe to the .config method of the PHY driver. The new function
will be called at phy_config() time.

I do believe I've converted all the possible call paths for creating
a PHY with PHY_FIXED_ID, so there is really no reason to maintain
compatibility with the old logic of retrieving a flat OF tree offset
from phydev->addr. We just pass 0 to phydev->addr now.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Bin Meng 
Tested-by: Bin Meng 
Message-Id: <20210216224804.3355044-2-olteanv@gmail.com>
[bmeng: keep fixedphy_probe(); update mdio-uclass.c to handle fixed phy]
Signed-off-by: Bin Meng 
Reviewed-by: Vladimir Oltean 
Reviewed-by: Priyanka Jain

net: phy: introduce fixed_phy_create for DSA CPU ports

2021-02-16T16:48:20+00:00

The DSA (Distributed Switch Architecture) implementation has made a
design decision when it got introduced to the Linux kernel in 2008.
That was to hide away from the user the CPU-facing Ethernet MAC, since
it does not make sense to register it as a struct net_device (UCLASS_ETH
udevice for U-Boot), because that would never be beneficial for a user:
they would not be able to use it for traffic, since conceptually, a
packet delivered to the CPU port should loop back into the system.

Nonetheless, DSA has had numerous growing pains due to the lack of a
struct net_device for the CPU port, but so far it has overcome them.
It is unlikely at this stage of maturity that this aspect of it will
change.

We would like U-Boot to present the same information as Linux, to be at
parity in terms of number of interfaces, so that ethNaddr environment
variables could directly be associated between U-Boot and Linux.
Therefore, we would implicitly like U-Boot to hide the CPU port from the
user as well.

But the paradox is that DSA still needs a struct phy_device to inform
the driver of the parameters of the link that it should configure the
CPU port to. The problem is that the phy_device is typically returned
via a call to phy_connect, which needs an udevice to attach the PHY to,
and to search its ofnode for the 'fixed-link' property. But we don't
have an udevice to present for the CPU port.

Since 99% of DSA setups are MAC-to-MAC connections between the switch
and the host Ethernet controller, the struct phy_device is going to be a
fixed PHY. This simplifies things quite a bit. In U-Boot, a fixed PHY
does not need an MDIO bus, and does not need an attached dev either.
Basically, the phy_connect call doesn't do any connection, it just
creates the fixed PHY.

The proposal of this patch is to introduce a new fixed_phy_create
function which will take a single argument: the ofnode that holds this:

	port@4 {
		reg = <4>;
		phy-mode = "internal";

		fixed-link {
			speed = <2500>;
			full-duplex;
		};
	};

and probe a fixed PHY driver using the information from this ofnode.
DSA will probably be the only user of this function.

Signed-off-by: Vladimir Oltean 
Reviewed-by: Claudiu Manoil