u-boot.git/arch/sh/cpu, branch master

reset: Remove addr parameter from reset_cpu()

2021-03-02T19:03:02+00:00

Historically, the reset_cpu() function had an `addr` parameter which was
meant to pass in an address of the reset vector location, where the CPU
should reset to.  This feature is no longer used anywhere in U-Boot as
all reset_cpu() implementations now ignore the passed value.  Generic
code has been added which always calls reset_cpu() with `0` which means
this feature can no longer be used easily anyway.

Over time, many implementations seem to have "misunderstood" the
existence of this parameter as a way to customize/parameterize the reset
(e.g.  COLD vs WARM resets).  As this is not properly supported, the
code will almost always not do what it is intended to (because all
call-sites just call reset_cpu() with 0).

To avoid confusion and to clean up the codebase from unused left-overs
of the past, remove the `addr` parameter entirely.  Code which intends
to support different kinds of resets should be rewritten as a sysreset
driver instead.

This transformation was done with the following coccinelle patch:

    @@
    expression argvalue;
    @@
    - reset_cpu(argvalue)
    + reset_cpu()

    @@
    identifier argname;
    type argtype;
    @@
    - reset_cpu(argtype argname)
    + reset_cpu(void)
    { ... }

Signed-off-by: Harald Seiler 
Reviewed-by: Simon Glass

treewide: convert bd_t to struct bd_info by coccinelle

2020-07-17T13:30:13+00:00

The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:

  It's a **mistake** to use typedef for structures and pointers.

Besides, using typedef for structures is annoying when you try to make
headers self-contained.

Let's say you have the following function declaration in a header:

  void foo(bd_t *bd);

This is not self-contained since bd_t is not defined.

To tell the compiler what 'bd_t' is, you need to include 

  #include 
  void foo(bd_t *bd);

Then, the include direcective pulls in more bloat needlessly.

If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:

  struct bd_info;
  void foo(struct bd_info *bd);

Right, typedef'ing bd_t is a mistake.

I used coccinelle to generate this commit.

The semantic patch that makes this change is as follows:

  
  @@
  typedef bd_t;
  @@
  -bd_t
  +struct bd_info
  

Signed-off-by: Masahiro Yamada

command: Remove the cmd_tbl_t typedef

2020-05-18T22:36:55+00:00

We should not use typedefs in U-Boot. They cannot be used as forward
declarations which means that header files must include the full header to
access them.

Drop the typedef and rename the struct to remove the _s suffix which is
now not useful.

This requires quite a few header-file additions.

Signed-off-by: Simon Glass

common: Drop net.h from common header

2020-05-18T21:33:31+00:00

Move this header out of the common header. Network support is used in
quite a few places but it still does not warrant blanket inclusion.

Note that this net.h header itself has quite a lot in it. It could be
split into the driver-mode support, functions, structures, checksumming,
etc.

Signed-off-by: Simon Glass

common: Move reset_cpu() to the CPU header

2020-01-17T19:02:31+00:00

Move this function out of common.h and into a relevant header file.

Signed-off-by: Simon Glass

common: Move enable/disable_interrupts out of common.h

2019-12-02T23:25:01+00:00

Move these two functions into the irq_funcs.h header file. Also move
interrupt_handler_t as this is used by the irq_install_handler() function.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

common: Move interrupt functions into a new header

2019-12-02T23:25:00+00:00

These functions do not use driver model but are fairly widely used in
U-Boot. But it is not clear that they will use driver model anytime soon,
so we don't want to label them as 'legacy'.

Move them to a new irq_func.h header file. Avoid the name 'irq.h' since it
is widely used in U-Boot already.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

arm: powerpc: Tidy up code style for interrupt functions

2019-12-02T23:24:59+00:00

Remove the unwanted space before the bracket.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

common: Move some cache and MMU functions out of common.h

2019-12-02T23:23:55+00:00

These functions belong in cpu_func.h. Another option would be cache.h
but that code uses driver model and we have not moved these cache
functions to use driver model. Since they are CPU-related it seems
reasonable to put them here.

Move them over.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

common: Move checkcpu() out of common.h

2019-12-02T23:23:14+00:00

This function belongs in cpu_func.h so move it over.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini