From 0ac5412e2c02b5f3f61ea05cc864c32e28d1351e Mon Sep 17 00:00:00 2001 From: skvidal Date: Mon, 16 May 2005 15:07:51 +0000 Subject: pychecker is my friend --- mock.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mock.py b/mock.py index 8b50e77..70f12ba 100644 --- a/mock.py +++ b/mock.py @@ -21,13 +21,11 @@ import sys import commands import rpmUtils import rpm -import sha import glob -import tempfile import shutil import types import grp -import pwd + from optparse import OptionParser __VERSION__ = '0.1' @@ -527,11 +525,11 @@ class Root: self.do_chroot(cmd, fatal=True) # create dir structure - for dir in ('RPMS', 'SRPMS', 'SOURCES', 'SPECS', 'BUILD', 'originals'): - cmd = "mkdir -p %s/%s" % (self.builddir, dir) + for subdir in ('RPMS', 'SRPMS', 'SOURCES', 'SPECS', 'BUILD', 'originals'): + cmd = "mkdir -p %s/%s" % (self.builddir, subdir) self.do_chroot(cmd, fatal = True) cmd = "chown %s.%s %s/%s" % (self.config['chrootuser'], - self.config['chrootgroup'], self.builddir, dir) + self.config['chrootgroup'], self.builddir, subdir) self.do_chroot(cmd, fatal = True) # rpmmacros default -- cgit