diff options
author | Michael E Brown <michael_e_brown@dell.com> | 2007-12-05 22:32:25 -0600 |
---|---|---|
committer | Michael E Brown <michael_e_brown@dell.com> | 2007-12-05 22:32:25 -0600 |
commit | 236441558e3a5921505a5657950411c5865d8715 (patch) | |
tree | 39ab9eaead481d1c8a350d7ec494de85a234fceb | |
parent | fc3a2ad3016ab8a5c20d71cbd34e9b40f056f7f5 (diff) | |
download | mock-236441558e3a5921505a5657950411c5865d8715.tar.gz mock-236441558e3a5921505a5657950411c5865d8715.tar.xz mock-236441558e3a5921505a5657950411c5865d8715.zip |
mount inside try block so problem mounting unmounts everything.
-rwxr-xr-x | py/mock.py | 4 | ||||
-rw-r--r-- | py/mock/backend.py | 8 |
2 files changed, 6 insertions, 6 deletions
@@ -431,8 +431,8 @@ def main(ret): elif options.mode in ('chroot', 'shell'): chroot.tryLockBuildRoot() - chroot._mountall() try: + chroot._mountall() if config_opts['internal_setarch']: mock.util.condPersonality(config_opts['target_arch']) cmd = ' '.join(args) @@ -450,8 +450,8 @@ def main(ret): for hdr in mock.util.yieldSrpmHeaders(args, plainRpmOk=1): pass chroot.tryLockBuildRoot() - chroot._mountall() try: + chroot._mountall() chroot.installSrpmDeps(*args) finally: chroot._umountall() diff --git a/py/mock/backend.py b/py/mock/backend.py index 0576b1f..2484457 100644 --- a/py/mock/backend.py +++ b/py/mock/backend.py @@ -237,8 +237,8 @@ class Root(object): # yum stuff self.state("running yum") - self._mountall() try: + self._mountall() if not self.chrootWasCleaned: self.chroot_setup_cmd = 'update' self._yum(self.chroot_setup_cmd, returnOutput=1) @@ -300,8 +300,8 @@ class Root(object): def yumInstall(self, *srpms): """figure out deps from srpm. call yum to install them""" # pass build reqs (as strings) to installer - self._mountall() try: + self._mountall() self._yum('install %s' % ' '.join(srpms), returnOutput=1) finally: self._umountall() @@ -349,9 +349,9 @@ class Root(object): # tell caching we are building self._callHooks('earlyprebuild') - self._mountall() - self.uidManager.becomeUser(self.chrootuid, self.chrootgid) try: + self._mountall() + self.uidManager.becomeUser(self.chrootuid, self.chrootgid) self.state("setup") srpmChrootFilename = self._copySrpmIntoChroot(srpm) |