diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2008-11-06 17:24:14 +0100 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2008-11-08 13:23:45 +0100 |
| commit | 06618ab4c99656facc8795f6943c4fb4315e2edc (patch) | |
| tree | b174dec7e23ef407bad20410aa9bb1fa1c98b59b | |
| parent | 61923e1c91b8de98e73f9fb305fed1dbcb1ca41e (diff) | |
| download | anaconda-06618ab4c99656facc8795f6943c4fb4315e2edc.tar.gz anaconda-06618ab4c99656facc8795f6943c4fb4315e2edc.tar.xz anaconda-06618ab4c99656facc8795f6943c4fb4315e2edc.zip | |
Do not stop and restart iscsid when rescanning disks/partitions (#470223)
anaconda kills and restarts iscsid each time an iscsi / zfcp disk gets added,
resulting in messages like these on tty4:
<28> Nov 6 11:30:06 iscsid: connection1:0 is operational now
<28> Nov 6 11:30:07 iscsid: iscsid shutting down.
<28> Nov 6 11:30:08 iscsid: iscsid with pid=1359 started
<28> Nov 6 11:30:09 iscsid: session
[iqn.2005-03.com.max:testdisk,192.168.1.100:3260] already running
<28> Nov 6 11:30:09 iscsid: connection1:0 is operational after recovery (1
attempts)
Esp. the "connection1:0 is operational after recovery (1 attempts)" clearly
indicates that this is not a good thing todo. iscsid is designed as a kernel
helper daemon, which when iscsi is used should be started and never stopped
again.
Note that this means iscsi.startup() also will not get called during the
partitionobjinit step, this is a no-op the first time as then the initiator
name has not been set yet, and if we go back and forth over this step we do not
want to start / stop iscsid, just as we don't want to do that for each iscsi
target added.
| -rw-r--r-- | partitions.py | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/partitions.py b/partitions.py index a006d93b0..57aa55536 100644 --- a/partitions.py +++ b/partitions.py @@ -54,7 +54,6 @@ def partitionObjectsInitialize(anaconda): # shut down all dm devices anaconda.id.diskset.closeDevices() anaconda.id.diskset.stopMdRaid() - anaconda.id.iscsi.shutdown() anaconda.id.zfcp.shutdown() # clean slate about drives @@ -63,9 +62,6 @@ def partitionObjectsInitialize(anaconda): if anaconda.dir == DISPATCH_BACK: return - # ensure iscsi devs are up - anaconda.id.iscsi.startup(anaconda.intf) - # ensure zfcp devs are up anaconda.id.zfcp.startup() |