From f165d65e82eaaf139a89cd8b3f58fbe60f8cbecd Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn@samba.org>
Date: Thu, 10 Apr 2014 10:30:40 +0200
Subject: echo_srv: Fix resource leak of s2 on error.

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
Reviewed-by: Simo Sorce <idra@samba.org>
---
 tests/echo_srv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/echo_srv.c b/tests/echo_srv.c
index 537de08..4c65d19 100644
--- a/tests/echo_srv.c
+++ b/tests/echo_srv.c
@@ -307,11 +307,11 @@ static int socket_dup(int s)
 
     /* Test dup2 */
     s = dup2(s2, s);
+    close(s2);
     if (s == -1) {
         perror("dup");
         return -1;
     }
-    close(s2);
 
     ZERO_STRUCT(srv_ss3);
     srv_ss3_len = sizeof(srv_ss3);
-- 
cgit