socket_wrapper.git/src, branch master

cmake: Define a library version for the noop lib

2021-03-15T07:22:33+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

cmake: Export cmake config for socket_wrapper_noop

2021-03-15T07:18:15+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

cmake: Set public include dir for socket_wrapper_noop target

2021-03-15T07:17:34+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

cmake: Set PRIVATE for linking libraries

2021-03-15T07:09:29+00:00

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher

swrap: wrap __close_nocancel() if available

2021-03-15T07:04:58+00:00

While it's no possible to inject swrap__close_nocancel() into
libc.so.6 directly, because it's no weak symbol, it seems to
be possible to inject it to other glibc libraries like
libpthread.so.0, which is better than nothing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14640

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

swrap: export a public socket_wrapper_indicate_no_inet_fd() helper function

2021-03-15T07:04:58+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14640

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

swrap: introduce a socket_wrapper_noop.so and socket_wrapper.h to provide noop stubs

2021-03-15T07:04:58+00:00

Applications with the need to call socket_wrapper_enabled() should link
against -lsocket_wrapper_noop in order to resolve the symbol at
link time.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14640

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

swrap: split out swrap_remove_wrapper() to handle swrap_close() and swrap_remove_stale()

2021-03-15T07:04:58+00:00

Except of closing the fd, both should do the same, even indicating a TCP
close in the pcap file.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14640

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

swrap: remember the libc_close() errno in swrap_close()

2021-03-15T07:04:58+00:00

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14640

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider

swrap: call libc_write() directly for internal fds

2021-03-15T07:04:58+00:00

Otherwise we may deadlock with a backtrace like this:

swrap_accept():
 ...
 SWRAP_LOCK_SI(si);
 swrap_pcap_dump_packet() ->
   write() ->
     swrap_write() ->
       SWRAP_LOCK_SI(si) -> abort()

This can happen if libc_open() called from swrap_pcap_get_fd()
return a stale fd. This may happen if glibc calls socket()
and closes it with __close_nocancel() instead of close().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14640

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider