From cf5bf1863d58f823f9c67b0e5dda3ba9261ccf27 Mon Sep 17 00:00:00 2001 From: arao Date: Wed, 18 Feb 2015 13:11:42 +0530 Subject: rpc: Fixing dereferencing after null check CID: 1124607 The pointer variable is checked for NULL and logged accordingly. Change-Id: Ied0d7f7ff33da22198eca65f14816b943cae5541 BUG: 789278 Signed-off-by: arao Reviewed-on: http://review.gluster.org/9674 Tested-by: Gluster Build System Reviewed-by: Niels de Vos Reviewed-by: Vijay Bellur --- rpc/rpc-lib/src/rpcsvc.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'rpc/rpc-lib/src/rpcsvc.c') diff --git a/rpc/rpc-lib/src/rpcsvc.c b/rpc/rpc-lib/src/rpcsvc.c index 67b71ea0e8..5717bedcf1 100644 --- a/rpc/rpc-lib/src/rpcsvc.c +++ b/rpc/rpc-lib/src/rpcsvc.c @@ -1531,9 +1531,15 @@ rpcsvc_program_unregister (rpcsvc_t *svc, rpcsvc_program_t *program) ret = 0; out: if (ret == -1) { - gf_log (GF_RPCSVC, GF_LOG_ERROR, "Program unregistration failed" - ": %s, Num: %d, Ver: %d, Port: %d", program->progname, - program->prognum, program->progver, program->progport); + if (program) { + gf_log (GF_RPCSVC, GF_LOG_ERROR, "Program " + "unregistration failed" + ": %s, Num: %d, Ver: %d, Port: %d", + program->progname, program->prognum, + program->progver, program->progport); + } else { + gf_log (GF_RPCSVC, GF_LOG_ERROR, "Program not found"); + } } return ret; -- cgit