From 93e3c9abce1a02ac724afa382751852fa5edf713 Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Wed, 29 Mar 2017 13:44:03 +0200 Subject: libglusterfs: provide standardized atomic operations The current macros ATOMIC_INCREMENT() and ATOMIC_DECREMENT() expect a lock as first argument. There are at least two issues with this approach: 1. this lock is unused on architectures that have atomic operations 2. some structures use a single lock for multiple variables By defining a gf_atomic_t type, the unused lock can be removed, saving a few bytes on modern architectures. Because the gf_atomic_t type locates the lock for the variable (in case of older architectures), each variable is protected the same on all architectures. This makes the behaviour across all architectures more equal (per variable locking, by a gf_lock_t or compiler optimization). BUG: 1437037 Change-Id: Ic164892b06ea676e6a9566f8a98b7faf0efe76d6 Signed-off-by: Niels de Vos Reviewed-on: https://review.gluster.org/16963 Smoke: Gluster Build System Reviewed-by: Xavier Hernandez NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Amar Tumballi Reviewed-by: Jeff Darcy --- libglusterfs/src/logging.h | 1 + 1 file changed, 1 insertion(+) (limited to 'libglusterfs/src/logging.h') diff --git a/libglusterfs/src/logging.h b/libglusterfs/src/logging.h index a6e318dc3f..78d57888f3 100644 --- a/libglusterfs/src/logging.h +++ b/libglusterfs/src/logging.h @@ -37,6 +37,7 @@ #endif #define GF_PRI_BLKSIZE PRId32 #define GF_PRI_SIZET "zu" +#define GF_PRI_ATOMIC PRIu64 #ifdef GF_DARWIN_HOST_OS #define GF_PRI_TIME "ld" -- cgit