From 24dd33929bbbc9a72360793048f17bf4e6cec8a3 Mon Sep 17 00:00:00 2001 From: Kaleb S KEITHLEY Date: Fri, 6 May 2016 13:04:38 -0400 Subject: libglusterfs (timer): race conditions, illegal mem access, mem leak While investigating gfapi memory consumption with valgrind, valgrind reported several memory access issues. Also see the timer 'registry' being recreated (shortly) after being freed during teardown due to the way it's currently written. Passing ctx as data to gf_timer_proc() is prone to memory access issues if ctx is freed before gf_timer_proc() terminates. (And in fact this does happen, at least in valgrind.) gf_timer_proc() doesn't need ctx for anything, it only needs ctx->timer, so just pass that. Nothing ever calls gf_timer_registry_init(). Nothing outside of timer.c that is. Making it and gf_timer_proc() static. Change-Id: Ia28454dda0cf0de2fec94d76441d98c3927a906a BUG: 1333925 Signed-off-by: Kaleb S KEITHLEY Reviewed-on: http://review.gluster.org/14247 NetBSD-regression: NetBSD Build System Smoke: Gluster Build System CentOS-regression: Gluster Build System Reviewed-by: Poornima G Reviewed-by: Niels de Vos Reviewed-by: Jeff Darcy --- glusterfsd/src/glusterfsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'glusterfsd') diff --git a/glusterfsd/src/glusterfsd.c b/glusterfsd/src/glusterfsd.c index d8bc01337b..0cf1763bdf 100644 --- a/glusterfsd/src/glusterfsd.c +++ b/glusterfsd/src/glusterfsd.c @@ -1493,7 +1493,7 @@ glusterfs_ctx_defaults_init (glusterfs_ctx_t *ctx) if (!ctx->logbuf_pool) goto out; - pthread_mutex_init (&(ctx->lock), NULL); + LOCK_INIT (&ctx->lock); pthread_mutex_init (&ctx->notify_lock, NULL); pthread_cond_init (&ctx->notify_cond, NULL); -- cgit