From 86701a0ececa5fdbbe08654516618baadc4555b7 Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Mon, 23 Nov 2015 12:20:09 +0530 Subject: build: Remove redundant options from GF_CFLAGS While configuring, GF_CFLAGS is being populated with redudndant options as follows: Normal mode: GF_CFLAGS = -g -O2 -g -O2 -Wformat -Werror=format-security \ -g -O2 -g -O2 -Wformat -Werror=format-security \ -Werror=implicit-function-declaration Debug mode: GF_CFLAGS = -g -O2 -g -O0 -DDEBUG -Wformat -Werror=format-security \ -g -O2 -g -O0 -DDEBUG -Wformat -Werror=format-security \ -Werror=implicit-function-declaration This patch is to remove this redundancy of options. Change-Id: Idf6f2536c2a8ae24ba257681fbe9dfdb8bfa4f19 BUG: 1198849 Signed-off-by: Anoop C S Reviewed-on: http://review.gluster.org/12714 Tested-by: NetBSD Build System Tested-by: Gluster Build System Reviewed-by: Kaleb KEITHLEY Reviewed-by: Jeff Darcy --- configure.ac | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'configure.ac') diff --git a/configure.ac b/configure.ac index a345b88078..e2cb20fe79 100644 --- a/configure.ac +++ b/configure.ac @@ -934,15 +934,18 @@ fi dnl check for gcc -Werror=implicit-function-declaration saved_CFLAGS=$CFLAGS +saved_GF_CFLAGS=$GF_CFLAGS CFLAGS="-Werror=implicit-function-declaration" +GF_CFLAGS="-Werror=implicit-function-declaration" AC_MSG_CHECKING([whether $CC accepts -Werror=implicit-function-declaration]) AC_COMPILE_IFELSE([AC_LANG_PROGRAM()], [cc_werror_implicit=yes], [cc_werror_implicit=no]) echo $cc_werror_implicit if test "x$cc_werror_implicit" = "xno"; then CFLAGS="$saved_CFLAGS" + GF_CFLAGS="$saved_GF_CFLAGS" else CFLAGS="$saved_CFLAGS $CFLAGS" - GF_CFLAGS="$GF_CFLAGS $CFLAGS" + GF_CFLAGS="$saved_GF_CFLAGS $GF_CFLAGS" fi dnl clang is mostly GCC-compatible, but its version is much lower, -- cgit