From f63eacecab3126e4e4580c979f8719be66ff7bf5 Mon Sep 17 00:00:00 2001 From: Atin Mukherjee Date: Wed, 26 Jul 2017 12:46:42 +0530 Subject: cli: error out incomplete CLI commands cli_cmd_bricks_parse () & cli_cmd_volume_remove_brick_parse () were not handling the the error cases where the command is incomplete with missing brick details which could lead to glusterd crashes. Credit : george.lian@nokia.com Change-Id: Ia6303457a2aa279465aa75d4e1cfcc948893d5de BUG: 1396327 Signed-off-by: Atin Mukherjee Reviewed-on: https://review.gluster.org/17870 Smoke: Gluster Build System CentOS-regression: Gluster Build System Reviewed-by: Jeff Darcy --- cli/src/cli.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'cli/src/cli.h') diff --git a/cli/src/cli.h b/cli/src/cli.h index 1e92d67519..a1be2b62d0 100644 --- a/cli/src/cli.h +++ b/cli/src/cli.h @@ -278,7 +278,8 @@ cli_cmd_volume_old_tier_parse (const char **words, int wordcount, int32_t cli_cmd_volume_remove_brick_parse (const char **words, int wordcount, - dict_t **options, int *question); + dict_t **options, int *question, + int *brick_count); int32_t cli_cmd_volume_replace_brick_parse (const char **words, int wordcount, -- cgit