From dd8306b2f2e38f5de1386461d7f33ac0b64f2886 Mon Sep 17 00:00:00 2001 From: Pranith Kumar K Date: Thu, 24 Dec 2015 14:29:33 +0530 Subject: performance/open-behind: Fix fdctx dump NULL dereference Also printing flags correctly in statedump now Change-Id: Ibfdd74aab5643ecc47d0a88f109d5d1050685f5a BUG: 1294051 Signed-off-by: Pranith Kumar K Reviewed-on: http://review.gluster.org/13076 Smoke: Gluster Build System NetBSD-regression: NetBSD Build System CentOS-regression: Gluster Build System Reviewed-by: Raghavendra G --- xlators/performance/open-behind/src/open-behind.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xlators/performance/open-behind/src/open-behind.c b/xlators/performance/open-behind/src/open-behind.c index 97c12fab41..efab88582f 100644 --- a/xlators/performance/open-behind/src/open-behind.c +++ b/xlators/performance/open-behind/src/open-behind.c @@ -865,14 +865,15 @@ ob_fdctx_dump (xlator_t *this, fd_t *fd) gf_proc_dump_write ("open_frame", "%p", ob_fd->open_frame); - gf_proc_dump_write ("open_frame.root.unique", "%p", - ob_fd->open_frame->root->unique); + if (ob_fd->open_frame) + gf_proc_dump_write ("open_frame.root.unique", "%p", + ob_fd->open_frame->root->unique); gf_proc_dump_write ("loc.path", "%s", ob_fd->loc.path); gf_proc_dump_write ("loc.ino", "%s", uuid_utoa (ob_fd->loc.gfid)); - gf_proc_dump_write ("flags", "%p", ob_fd->open_frame); + gf_proc_dump_write ("flags", "%d", ob_fd->flags); UNLOCK (&fd->lock); -- cgit