From 822dd79db99e0aa221ed90fdf8bb91fbcdfcd66f Mon Sep 17 00:00:00 2001 From: ShyamsundarR Date: Thu, 13 Sep 2018 13:12:47 -0400 Subject: core: move logs which are only developer relevant to DEBUG level For each release, we move certain logs on master that are meant as an indicator to contributors to correct or adapt to core infrastructure changes in libglusterfs and other places. This commit achieves the above. Change-Id: I4157a7ec7d5ec9c2948b2bbc1e4cb8317f28d6b8 Updates: bz#1628620 Signed-off-by: ShyamsundarR --- libglusterfs/src/dict.c | 6 +++--- libglusterfs/src/graph.c | 2 +- libglusterfs/src/options.c | 2 +- libglusterfs/src/xlator.c | 2 +- rpc/xdr/src/glusterfs3.h | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libglusterfs/src/dict.c b/libglusterfs/src/dict.c index 2e69da98fd..d75ce11c01 100644 --- a/libglusterfs/src/dict.c +++ b/libglusterfs/src/dict.c @@ -38,14 +38,14 @@ struct dict_cmp { #define VALIDATE_DATA_AND_LOG(data, type, key, ret_val) \ do { \ if (!data || !data->data) { \ - gf_msg_callingfn("dict", GF_LOG_WARNING, EINVAL, \ - LG_MSG_INVALID_ARG, "data is NULL"); \ + gf_msg_callingfn("dict", GF_LOG_DEBUG, EINVAL, LG_MSG_INVALID_ARG, \ + "data is NULL"); \ return ret_val; \ } \ /* Not of the asked type, or old version */ \ if ((data->data_type != type) && \ (data->data_type != GF_DATA_TYPE_STR_OLD)) { \ - gf_msg_callingfn("dict", GF_LOG_INFO, EINVAL, LG_MSG_INVALID_ARG, \ + gf_msg_callingfn("dict", GF_LOG_DEBUG, EINVAL, LG_MSG_INVALID_ARG, \ "key %s, %s type asked, has %s type", key, \ data_type_name[type], \ data_type_name[data->data_type]); \ diff --git a/libglusterfs/src/graph.c b/libglusterfs/src/graph.c index 2a213d2c48..a105c0cd72 100644 --- a/libglusterfs/src/graph.c +++ b/libglusterfs/src/graph.c @@ -393,7 +393,7 @@ _log_if_unknown_option(dict_t *dict, char *key, data_t *value, void *data) found = xlator_volume_option_get(xl, key); if (!found) { - gf_msg(xl->name, GF_LOG_WARNING, 0, LG_MSG_XLATOR_OPTION_INVALID, + gf_msg(xl->name, GF_LOG_DEBUG, 0, LG_MSG_XLATOR_OPTION_INVALID, "option '%s' is not recognized", key); } diff --git a/libglusterfs/src/options.c b/libglusterfs/src/options.c index 30607d2e39..a96828447f 100644 --- a/libglusterfs/src/options.c +++ b/libglusterfs/src/options.c @@ -969,7 +969,7 @@ xl_opt_validate(dict_t *dict, char *key, data_t *value, void *data) stub->errstr = errstr; if (fnmatch(opt->key[0], key, FNM_NOESCAPE) != 0) { - gf_msg(xl->name, GF_LOG_WARNING, 0, LG_MSG_INVALID_ENTRY, + gf_msg(xl->name, GF_LOG_DEBUG, 0, LG_MSG_INVALID_ENTRY, "option '%s' is deprecated, preferred is '%s', " "continuing with correction", key, opt->key[0]); diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c index 6975fbbd15..0f21ea46ed 100644 --- a/libglusterfs/src/xlator.c +++ b/libglusterfs/src/xlator.c @@ -335,7 +335,7 @@ xlator_dynload_newway(xlator_t *xl) xlapi = dlsym(handle, "xlator_api"); if (!xlapi) { - gf_msg("xlator", GF_LOG_INFO, 0, LG_MSG_DLSYM_ERROR, + gf_msg("xlator", GF_LOG_DEBUG, 0, LG_MSG_DLSYM_ERROR, "dlsym(xlator_api) on %s. " "Fall back to old symbols", dlerror()); diff --git a/rpc/xdr/src/glusterfs3.h b/rpc/xdr/src/glusterfs3.h index b8ef394aba..6ab80a8292 100644 --- a/rpc/xdr/src/glusterfs3.h +++ b/rpc/xdr/src/glusterfs3.h @@ -741,7 +741,7 @@ dict_to_xdr(dict_t *this, gfx_dict *dict) xpair->value.gfx_value_u.other.other_len = dpair->value->len; /* Change this to INFO, after taking the above down */ - gf_msg("dict", GF_LOG_INFO, EINVAL, LG_MSG_DICT_SERIAL_FAILED, + gf_msg("dict", GF_LOG_DEBUG, EINVAL, LG_MSG_DICT_SERIAL_FAILED, "key '%s' would not be sent on wire in the future", dpair->key); break; -- cgit