From 31dcbb61487ac82b5ae61435add98b0fd1d5e8cc Mon Sep 17 00:00:00 2001 From: Shwetha Acharya Date: Mon, 24 Sep 2018 15:03:18 +0530 Subject: mgmt/glusterd: NULL pointer dereferencing clang fix Added a condition check to resolve the issue Change-Id: I1954e91f7487c052caf5cf98c954d204242f0af9 Updates: bz#1622665 Signed-off-by: Shwetha Acharya --- xlators/mgmt/glusterd/src/glusterd-snapshot.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xlators/mgmt/glusterd/src/glusterd-snapshot.c b/xlators/mgmt/glusterd/src/glusterd-snapshot.c index 943352f19c..543d677f42 100644 --- a/xlators/mgmt/glusterd/src/glusterd-snapshot.c +++ b/xlators/mgmt/glusterd/src/glusterd-snapshot.c @@ -8116,6 +8116,12 @@ glusterd_snapshot_clone_postvalidate(dict_t *dict, int32_t op_ret, if (snap_vol) snap = snap_vol->snapshot; + else { + ret = -1; + gf_msg(this->name, GF_LOG_ERROR, 0, GD_MSG_SNAP_NOT_FOUND, + "Snapshot volume is null"); + goto out; + } /* Fetch snap object from snap_vol and delete it all in case of * * a failure, or else, just delete the snap object as it is not * -- cgit