glusterd: Removing redundant NULL checks for this and other cleanups. (#1735)

* glusterd: Removing redundant NULL checks for this

Issue: It has been noticed that the NULL checks performed
on `this` are actually being done on `THIS` as `this` is
derived from `THIS`. If the `THIS` had been NULL, the
crash would have happened before itself.

Fix: Basically removing the validations and assertion
functions which check if `this` is NULL.

Fixes: #1596
Signed-off-by: srijan-sivakumar <ssivakum@redhat.com>

* Made changes wrt review comments received.

Fixes: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>

* glusterd: The efficient usage of `THIS` and `this`.

This commit addresses the review comments and tries to
change code in more places wherein the `THIS` and `this` can
be handled efficiently.

Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>

* Updated commit to address review comments.

Updates: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>

* Addressing Review comments.

Updates: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>

* Made changes after regression failure.

Updates: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>

* One has to be careful while working with c

Instead of a `||` operation, the cleanup left out
with `|`. Does the compiler ceck for these things?

Updates: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>

* Fixing clang-format issues.

Change-Id: I68c52249af66080f59f57e558901f2654bd43cd8
Updates: #1596
Signed-off-by: srijan-sivakumar <ssivakumar@redhat.com>

Co-authored-by: srijan-sivakumar <ssivakumar@redhat.com>

0 files changed, 0 insertions, 0 deletions