glusterfs.git/xlators, branch v3.5.3beta2

Posix: Brick failure detection fix for ext4 filesystem

2014-10-28T16:33:48+00:00

Issue: stat() on XFS has a check for the filesystem status but
ext4 does not.

Fix: Replacing stat() call with open, write and read  to a new file under the
"brick/.glusterfs" directory. This change will work for xfs, ext4 and other
fileystems.

Change-Id: Id03c4bc07df4ee22916a293442bd74819b051839
BUG: 1130204
"Signed-off-by: Lalatendu Mohanty "
"Reviewed-on: http://review.gluster.org/8213"
"Reviewed-by: Niels de Vos "
"Tested-by: Gluster Build System "
(cherry picked from commit a7ef6eea4d43afdba9d0453c095e71e6bf22cdb7)
Signed-off-by: Lalatendu Mohanty 
Reviewed-on: http://review.gluster.org/8989
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

cluster/afr: Fix excessive logging in glfsheal log file

2014-10-27T15:47:49+00:00

Wrong afr_local_t instance was being used in the missing entry sh
check in afr_self_heal(), which was leading to entrylk failure messages
of the following kind in glfsheal logfile:

[2014-10-21 12:39:04.109875] I
[afr-self-heal-common.c:2146:afr_sh_post_nb_entrylk_missing_entry_sh_cbk]
0-vol-replicate-1: Non blocking entrylks failed

The fix involves sending the right "local" to
afr_can_start_missing_entry_gfid_self_heal().

After fixing this, there were two more codepaths giving out too many log messages
of the following kinds:

[2014-10-21 22:19:29.568533] E [afr-self-heal-data.c:1611:afr_sh_data_open_cbk]
0-dis-rep-replicate-1: open of 8a858b02-0fc7-4713-9f61-8ca28dea82c0
failed on child dis-rep-client-2 (Stale file handle)

[2014-10-21 22:19:29.577948] E [afr-self-heal-entry.c:2353:afr_sh_post_nonblocking_entry_cbk]
0-dis-rep-replicate-1: Non Blocking entrylks failed for ff9c82c4-5c0c-4ed9-b745-604a28dc352d.

which are also fixed appropriately as part of this patch.

Change-Id: Idd8d8e5735ee7a4ac36f369525f96e53276e0859
BUG: 1153629
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/8965
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

logs: Do selective logging for errnos

2014-10-22T07:32:40+00:00

        Backport of http://review.gluster.org/8918
                    http://review.gluster.org/8955

Problem:
Just after replace-brick the mount logs are filled with ENOENT/ESTALE
warning logs because the file is yet to be self-healed now that the
brick is new.

Fix:
Do conditional logging for the logs. ENOENT/ESTALE will be logged at
lower log level. Only when debug logs are enabled, these logs will
be written to the logfile.

BUG: 1155073
Change-Id: Icf06f2fc4f2f91e199de24a88bcb0ce9b8955ebd
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8960
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

protocol/client: change log level for lookup

2014-10-21T15:41:25+00:00

Problem:
On 3.5 branch, http://review.gluster.org/8294 causes the server to return ENOENT
(as opposed to ESTALE in master branch) if file does not exist. When AFR does
entry self-heals (either from the mount or shd or by the `heal info` command), it
does a gfid-lookup with loc.name == NULL, causing the corresponding log file to be
flooded with messages like this:

[2014-10-15 11:12:57.405428] W [client-rpc-fops.c:2761:client3_3_lookup_cbk]
0-testvol-client-1: remote operation failed: No such file or directory. Path:

(760b4427-2fb9-4a67-9f55-e8e8d78e452f)

Fix:
Change log level for ENOENT and ESTALE errors to DEBUG

Change-Id: Ideb88d9cb609d077e02efe703cd28155985d7513
BUG: 1153904
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/8937
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Niels de Vos

glusterd: pass the bind-address to starting services

2014-10-21T15:38:50+00:00

When the transport.socket.bind-address option is set to a hostname or
ip-address, the services started by GlusterD fail to connect to the
management daemon. GlusterD always forces the services to connect to the
"localhost" hostname, even if it is not listening on that address.

GlusterD should take the transport.socket.bind-address option into
consideration, and pass that to the glusterfs-clients with the -s or
--volfile commandline parameter.

Note that this is not a change that removes all hard-coded dependencies
on "localhost". This change merely makes it possible to start required
services when the transport.socket.bind-address option is set.

Cherry picked from commit 283fa797f4bf98130b42c36972305b8cb6e5aaaf:
> Change-Id: I36a0ed6c69342e6327adc258fea023929055d7f2
> BUG: 1149863
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/8908
> Tested-by: Gluster Build System 
> Reviewed-by: Jeff Darcy 
> Reviewed-by: Krishnan Parthasarathi 
> Tested-by: Krishnan Parthasarathi 

Change-Id: I36a0ed6c69342e6327adc258fea023929055d7f2
BUG: 1149857
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8952
Tested-by: Gluster Build System

glusterd: make bricks respect 'transport.socket.bind-address'

2014-10-21T15:38:18+00:00

When GlusterD starts the brick processes, these will listen on all
interfaces. When the 'transport.socket.bind-address' option is set in
glusterd.vol, the brick processes should only listen on the specified
hostname or IP-address.

Cherry picked from commit 430b874c4f1a171c106a9e1e6507e14e79805a1d:
> Change-Id: I8e7d1f294904081137c23f3446261329d0d13bba
> BUG: 1149863
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/8910
> Tested-by: Gluster Build System 
> Reviewed-by: Krishnan Parthasarathi 
> Tested-by: Krishnan Parthasarathi 

Change-Id: I8e7d1f294904081137c23f3446261329d0d13bba
BUG: 1149857
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8953
Tested-by: Gluster Build System

glusterd/quota: Heal pgfid xattr on existing data when the quota is

2014-10-20T16:13:34+00:00

enable

        Backport of: http://review.gluster.org/8878

The pgfid extended attributes are used to construct the ancestry path
(from the file to the volume root) for nameless lookups on files.
As NFS relies on nameless lookups heavily, quota enforcement through NFS
would be inconsistent if quota were to be enabled on a volume with
existing data.

Solution is to heal the pgfid extended attributes as a part of lookup
perfomed by quota-crawl process. In a posix lookup check for pgfid xattr
and if it is missing set the xattr.

Change-Id: I956128907aa1d975cd5719ed3ab2f4f9b37d4c31
BUG: 1153900
Signed-off-by: vmallika 
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/8938
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

cluster/afr: Fix sizeof typo

2014-10-18T08:40:11+00:00

Change-Id: Ib82a1c4967f0880c91c114e4baae08bdbe77bb60
BUG: 1153626
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8935
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

Only cleanup priv->shd.statistics if created

2014-10-07T07:42:29+00:00

It is possible that the statistics array was never created and
dereferencing it may case a segfault.

BUG: 1147156
Change-Id: If905457ba985add62c3ed543bced1313640af762
Signed-off-by: Tiziano Müller 
Reviewed-on: http://review.gluster.org/8873
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Niels de Vos

mount/fuse: Handle fd resolution failures

2014-10-01T10:44:28+00:00

        Backport of http://review.gluster.org/8402

Problem:
Even when the fd resolution failed, the fop is continuing on the
new graph which may not have valid inode. This lead to NULL layout
subvols in dht which lead to crash in fsync after graph migration.

Fix:
- Remove resolution error handling in FUSE_FOP as it was only added
  to handle fd migration failures.
- check in fuse_resolve_done for fd resolution failures and fail the
  fop right away.
- loc resolution failures are already handled in the corresponding
  fops.
- Return errno from state->resolve.op_errno in resume functions.
- Send error to fuse on frame allocation failures.
- Removed unused variable state->resolved
- Removed unused macro FUSE_FOP_COOKIE

BUG: 1136835
Change-Id: I5074f7a9b177c54051ef37a4f73de7f8d1fcc5b7
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8595
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos