glusterfs.git/xlators/protocol/server, branch release-9

rpcsvc/transport: gracefully disconnect when graph is not ready (#1671)

2020-10-27T07:12:03+00:00

* rpcsvc/transport: gracefully disconnect when graph is not ready.

There was a crash reported when the brick rpc get's an accept
request from a client before the server xlator is fully inited.

The fix https://review.gluster.org/22339/ solves
the crash, but it leaves the connection alive with out adding
the rpc to xprts list of server conf. This will leads to problems
with upcall, dump, and other cleanup codes.

So this patch will make the rpc to fail and disconnect if a
connection attempted before the server is fully inited.

Change-Id: I3bf1113c0da4c2614afaa2c0f4eb6abfb0d26ed0
Signed-off-by: Mohammed Rafi KC

core: configure optimum inode table hash_size for shd (#1576)

2020-10-11T05:26:57+00:00

In brick_mux environment a shd process consume high memory.
After print the statedump i have found it allocates 1M per afr xlator
for all bricks.In case of configure 4k volumes it consumes almost total
6G RSS size in which 4G consumes by inode_tables

[cluster/replicate.test1-replicate-0 - usage-type gf_common_mt_list_head memusage]
size=1273488
num_allocs=2
max_size=1273488
max_num_allocs=2
total_allocs=2

inode_new_table function allocates memory(1M) for a list of inode and dentry hash.
For shd lru_limit size is 1 so we don't need to create a big hash table so to reduce
RSS size for shd process pass optimum bucket count at the time of creating inode_table.

Change-Id: I039716d42321a232fdee1ee8fd50295e638715bb
Fixes: #1538
Signed-off-by: Mohit Agrawal

rpcsvc: Add latency tracking for rpc programs

2020-09-04T05:14:17+00:00

Added latency tracking of rpc-handling code. With this change we
should be able to monitor the amount of time rpc-handling code is
consuming for each of the rpc call.

fixes: #1466
Change-Id: I04fc7f3b12bfa5053c0fc36885f271cb78f581cd
Signed-off-by: Pranith Kumar K

xlators/protocol/server: lto-type-mismatch

2020-07-07T14:51:58+00:00

  [  202s] server-common.h:192:1: warning: type of 'server4_post_link' does not match original declaration [-Wlto-type-mismatch]
  [  202s]   192 | server4_post_link(server_state_t *state, gfx_common_3iatt_rsp *rsp, inode_t *inode, struct iatt *stbuf, struct iatt *pre, struct iatt *post);
  [  202s]       | ^
  [  202s] server-common.c:847:1: note: type mismatch in parameter 7
  [  202s]   847 | server4_post_link(server_state_t *state, gfx_common_3iatt_rsp *rsp,inode_t *inode, struct iatt *stbuf, struct iatt *pre, struct iatt *post, dict_t *xdata)
  [  202s]       | ^
  [  202s] server-common.c:847:1: note: 'server4_post_link' was previously declared here

goes back to glusterfs-6 at least.

Only a warning, more of a truth-and-beauty thing.

Change-Id: Ib4a74b2d00aec519e9d80a4bdeca20eb6273777f
Updates: #1002
Signed-off-by: Kaleb S. KEITHLEY

build: Pass $(LIB_DL) using prog_LDADD or lib_LIBADD

2020-06-20T07:56:13+00:00

"Program and Library Variables" section from Automake manual suggests
the following:

. . .
_LDADD and _LIBADD are inappropriate for passing program-specific linker
flags (except for -l, -L, -dlopen and -dlpreopen). Use the _LDFLAGS
variable for this purpose.
. . .

Therefore it is reasonable to move $(LIB_DL) additon from _LDFLAGS to
_LDADD and _LIBADD variables for program and library respectively.

Change-Id: Id8b4734c207ab28a08bcce683d316cdc7acb0bcd
Updates: #1000
Signed-off-by: Anoop C S

protocol/server: Fix coverity issue RESOURCE_LEAK

2020-04-08T20:29:03+00:00

Handle case of arg not freed
CID: 1422174

Updates: #1060
Change-Id: Ibd03908a3ea8369035c2b7f6e024b3e5be48f436
Signed-off-by: Sheetal Pamecha

core[brick_mux]: brick crashed when creating and deleting volumes over time

2020-03-04T03:47:26+00:00

Problem: In brick_mux environment, while volumes are created/stopped in a loop
         after running a long time the main brick is crashed.The brick is crashed
         because the main brick process was not cleaned up memory for all objects
         at the time of detaching a volume.
         Below are the objects that are missed at the time of detaching a volume
         1) xlator object for a brick graph
         2) local_pool for posix_lock xlator
         3) rpc object cleanup at quota xlator
         4) inode leak at brick xlator

Solution: To avoid the crash resolve all leak at the time of detaching a brick
Change-Id: Ibb6e46c5fba22b9441a88cbaf6b3278823235913
updates: #977
Signed-off-by: Mohit Agrawal

protocol/server-helpers: structure logging

2020-02-27T13:18:16+00:00

convert gf_msg() to gf_smsg()

Updates: #657

Change-Id: Ic7b38b646fa0932f7c1562467866137c4567e1f1
Signed-off-by: yatip

protocol/server-rpc-fops_v2: structure logging

2020-02-27T09:04:56+00:00

convert gf_msg() to gf_smsg()

Updates: #657

Change-Id: I01146bcd06bca44faeca29da48fab1ee3fc51e00
Signed-off-by: yatip

protocol/server: structure logging

2020-02-20T08:44:43+00:00

Convert all gf_msg() to gf_smsg()

Updates: #657
Change-Id: Ic54b03f05e2766c87f50df0b3a66803b5519fad9
Signed-off-by: yatip