glusterfs.git/xlators/protocol/client/src/client-callback.c, branch v3.11.0

gluster: Typos in logs and comments

2017-01-19T20:37:08+00:00

Replaced 'recieve' with 'receive'.

Change-Id: I4c1c9147db5437feb81e4c83ed074440aaa28e07
BUG: 1414645
Signed-off-by: N Balachandran 
Reviewed-on: http://review.gluster.org/16429
Smoke: Gluster Build System 
Reviewed-by: Manikandan Selvaganesh 
Tested-by: Manikandan Selvaganesh 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

protocol/client (no 1): fix unused variable warnings/errors

2016-09-05T11:05:13+00:00

http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.

However 14085 won't pass the smoke test until all the warnings are
fixed.

BUG: 1369124
Change-Id: I8a24e3c02144860859d653ab7115895fb3066378
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/15338
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Anuradha Talur 
Reviewed-by: Niels de Vos

protocol: Add framework to send transaction id with recall

2016-06-10T11:03:40+00:00

Issue:
The upcall(cache invalidation/recall) event is sent from the bricks
to clients. In AFR/EC setup, it can so happen that all the bricks
will send the upcall for the same event, and if AFR/EC doesn't filter
out these duplicate notifications, the logic above cluster xlators
can fail.

Solution:
Use transaction id to filter out duplicate notifications.

This patch adds framework for duplicate notifications.
AFR/EC can build up on this patch for deduping the notifications

Change-Id: I66b08e63b8799bc5932f2b2545376138a5701168
BUG: 1319992
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/14647
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Raghavendra G

upcall: pass dict with xattrs on xattr invalidation

2016-05-19T09:28:07+00:00

In case of xattr invalidation, return a dict containing
the updated xattrs.

[ndevos: move chunks to change 12995 and only address the xattrs-dict here]

Change-Id: I8733f06a519a9a0f24be1bb4b2c38c9c9dce0ce2
BUG: 1211863
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/12996
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: soumya k 
Tested-by: soumya k

Protocol: Add lease fop

2016-04-30T05:37:39+00:00

Change-Id: I64c361d3e4ae86d57dc18bb887758d044c861237
BUG: 1319992
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/11597
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Pranith Kumar Karampuri

protocol client/server: Fix client-server handshake

2016-03-10T17:24:33+00:00

Problem:
Currently on a successful connection between protocol
server and client, the protocol client initiates a
CHILD_UP event in the client stack. At this point in
time, only the connection between server and client is
established, and there is no guarantee that the server
side stack is ready to serve requests.

It works fine now, as most server side translators are
not dependent on any other factors, before being able
to serve requests today and hence they are up by the time
the client stack translators receive the CHILD_UP (initiated
by client handshake).

The gap here is exposed when certain server side translators
like NSR-Server for example, have a couple of protocol clients
as their child(connecting them to other bricks), and they
can't really serve requests till a quorum of their children are
up. Hence these translators should defer sending CHILD_UP
till they have enough children up, and the same needs to be
propagated to the client stack translators.

Fix:
Maintain a child_up variable in both the protocol client
and protocol server translators. The protocol server should
update this value based on the CHILD_UP and CHILD_DOWN
events it receives from the translators below it. On receiving
such an event it should forward that event to the client.
The protocol client on receiving such an event should forward
it up the client stack, thereby letting the client translators
correctly know that the server is up and ready to serve.

The clients connecting later(long after a server has initialized
and processed it's CHILD_UP events), will receive a child_up status
as part of the handshake, and based on the status of the server's
child_up, can either propagate a CHILD_UP event or defer it.

Change-Id: I0807141e62118d8de9d9cde57a53a607be44a0e0
BUG: 1312845
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13549
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

upcall: free the xdr* allocations

2016-01-14T11:39:24+00:00

Free the xdr string allocations after decoding the upcall
cache_invalidation request.

Change-Id: I0ffc64f587d6c8566cba76cf08148f937a735926
BUG: 1295107
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/13232
Reviewed-by: Niels de Vos 
Tested-by: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY

protocol/client : porting log messages to new framework

2015-06-15T13:26:43+00:00

Change-Id: I9bf2ca08fef969e566a64475d0f7a16d37e66eeb
BUG: 1194640
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/10042
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

build: do not #include "config.h" in each file

2015-05-29T12:43:17+00:00

Instead of including config.h in each file, and have the additional
config.h included from the compiler commandline (-include option).

When a .c file tests for a certain #define, and config.h was not
included, incorrect assumtions were made. With this change, it can not
happen again.

BUG: 1222319
Change-Id: I4f9097b8740b81ecfe8b218d52ca50361f74cb64
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10808
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Pranith Kumar Karampuri

Upcall: Replaced opaque gfid with string in rpc cbk args

2015-04-30T12:11:31+00:00

For GF_CBK_CACHE_INVALIDATION, have changed the type of gfid
to be string (cannonical form) instead of opaque byte format
to ensure correctness across platforms supporting different
endianness.

BUG: 1200262
Change-Id: Iac4372714f4b4ebcd9c4393aaf46ceba3f37f587
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/10224
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System