glusterfs.git/xlators/features/snapview-server/src/snapview-server.c, branch v3.8dev

snapview: Fixing the coverity issues

2015-04-04T18:00:47+00:00

Coverity CIDs:
1228601
1220056
1238185
1257624

Change-Id: Idb4cc3b44bc3ccb8b497ce355e1e3bacfb176db9
BUG: 789278
Signed-off-by: Nandaja Varma 
Reviewed-on: http://review.gluster.org/9615
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Avoid conflict between contrib/uuid and system uuid

2015-04-04T17:48:35+00:00

glusterfs relies on Linux uuid implementation, which
API is incompatible with most other systems's uuid. As
a result, libglusterfs has to embed contrib/uuid,
which is the Linux implementation, on non Linux systems.
This implementation is incompatible with systtem's
built in, but the symbols have the same names.

Usually this is not a problem because when we link
with -lglusterfs, libc's symbols are trumped. However
there is a problem when a program not linked with
-lglusterfs will dlopen() glusterfs component. In
such a case, libc's uuid implementation is already
loaded in the calling program, and it will be used
instead of libglusterfs's implementation, causing
crashes.

A possible workaround is to use pre-load libglusterfs
in the calling program (using LD_PRELOAD on NetBSD for
instance), but such a mechanism is not portable, nor
is it flexible. A much better approach is to rename
libglusterfs's uuid_* functions to gf_uuid_* to avoid
any possible conflict. This is what this change attempts.

BUG: 1206587
Change-Id: I9ccd3e13afed1c7fc18508e92c7beb0f5d49f31a
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10017
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

avoid memory leaks in snapview-server

2015-01-08T10:05:14+00:00

* snapview-server in readdirp, creates the inode for entries with names "." and
  ".." for each readdirp operation without creating dentries leading to memleak.
  It should have avoided creation of inodes for those entries

Change-Id: I3b2025fd10872fcc3303d0becec764ffd4e37601
BUG: 1179663
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/9404
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

uss/gluster: In SVS, check for entry-point in dict only if inode_ctx is

2014-12-16T13:33:44+00:00

not available

Change-Id: I990487003b712bf4aed8f54291417965f301655e
BUG: 1172430
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/9265
Tested-by: Gluster Build System 
Reviewed-by: Sachin Pandit 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

features/snapview-client: handle readdir requests differently for samba

2014-12-10T04:27:33+00:00

* For samba export, the entry point is also added to the readdir response.

Change-Id: I825c017e0f16db1f1890bb56e086f36e6558a1c2
BUG: 1168875
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/9218
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

uss/gluster: Send success on parent lookup of entry-point

2014-12-05T11:22:20+00:00

When a lookup sent to snapview-server for entry-point directory
protocol server first tries to resolve gfid of a parent directory.

looking up the parent gfid from a latest snapshot can fail if the
volume is a restored volume. As this gfid is already looked-up by
snapview-client, we can return success for the parent gfid.

Change-Id: Ic9b20561ef79b93032f07c3a81eae54a94e1747b
BUG: 1162498
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/9229
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Vijay Bellur

uss: CIFS gives error while accessing .snaps directory

2014-12-03T14:47:24+00:00

CIFS sends getxattr call while accessing .snaps directory.
snapview server should return ENODATA if getxattr is called
on .snaps folder. Also flush on .snaps folder should be handled.

Windows client sends and getxattr call on the parent folder
of .snaps with a special key to get the real filename of a file.
This is used by samba to do case insensitive check of files.

Fixed few FreeBSD compilation error.

bug: 1168875

Change-Id: I74d5cb4419568c8ed8709ba6d1ddff0e41392204
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/9211
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

USS : fill proper uid and gid during a access call from nfs

2014-12-01T16:04:06+00:00

Problem : when an user tries to access a file/folder for which
he does not have a proper permission required then fuse gives out
a proper error "Permission denied", but nfs does not give out that
error, rather he can access the file/folder. The reason being uid and
gid of call frame stack takes a default value of uid and gid which
point to root permission.

Solution : Set a proper uid and gid during a access call from nfs

Change-Id: Ib060706fde66ec7e60f242fab1f3e59122ed2245
BUG: 1167580
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/9194
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

gluster/uss: Handle ESTALE in snapview client when NFS server restarted

2014-11-26T06:26:04+00:00

When NFS server is restarted inode-context is lost.
Nameless lookup will be sent to regular volume.
If the gfid is from virtual graph, lookup will fail
with ESTALE. We need to send a lookup to snapview server

Change-Id: I22920614f0d14cb90b53653fce95b6b70023eba6
BUG: 1166197
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/9153
Tested-by: Gluster Build System 
Reviewed-by: Sachin Pandit 
Reviewed-by: Vijay Bellur

uss/snapd: Handle readlink fops on snap view server

2014-11-14T14:27:36+00:00

Handle readlink fops in case of symlinks on
snap view server

BUG: 1162462
Change-Id: Ia08e9e9c1c61e06132732aa580c5a9fd5e7c449b
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/9102
Reviewed-by: Vijaikumar Mallikarjuna 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur