glusterfs.git/xlators/features/snapview-client/src/snapview-client.c, branch v4.0dev

uss/svc: fix double free on xdata dictionary

2017-07-09T05:23:48+00:00

we were taking unref on wrong dictionary which results
in wrong memory access.

Change-Id: Ic25a6c209ecd72c9056dfcb79fabcfc650dd3c1e
BUG: 1467513
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: https://review.gluster.org/17691
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Atin Mukherjee

svc: send revalidate lookup on special dir

2017-07-09T04:57:48+00:00

.snaps directory is a virtual direcotory, that doesn't
exist on the backend. Even though it is a special dentry,
it doesn't have a dedicated inode. So the inode number is
always random. Which means it will get different inode
number when reboot happens on snapd process.

Now with windows client the show-direcotry feature requires
a lookup on the .snpas direcoty post readdirp on root.
If the snapd restarted after a lookup, then subsequent lookup
will fail, because linked inode will be stale.

This patch will do a revalidate lookup with a new inode.

Change-Id: If97c07ecb307cefe7c86be8ebd05e28cbf678d1f
BUG: 1467513
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: https://review.gluster.org/17690
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Smoke: Gluster Build System

features/uss: Remove redundant dict_unref

2017-01-06T18:04:39+00:00

In case dict_set_dynstr_with_alloc fails, dict_unref is done
when exection jumps to label 'out'.

Change-Id: I083386b7f85207348ba0bc353b5d1036ab821a15
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/16321
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

snapshot/uss: client-side log is filled with "invalid-argument" error

2016-05-31T18:54:51+00:00

xdata is used without checking if it is NULL or not.

Change-Id: Ib6ddaab28ec3b430b8d646aada0456d3cc9978cb
BUG: 1339149
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/14511
Smoke: Gluster Build System 
Reviewed-by: Raghavendra Talur 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

snapshot/uss: client log is filled with "invalid argument: inode" error

2016-05-25T14:23:37+00:00

svc_inode_ctx_get is called even if inode is NULL. We should not call
this function if inode is NULL

Change-Id: I5c3f17633ca88e5b6f40d4acf14a09e14b7ef62b
BUG: 1339149
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/14525
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

snapshot: svc_stat collides with define from /usr/include/rpc/svc.h

2016-04-27T09:11:56+00:00

Compiling fails with this error:

    snapview-client.c:559:24: error: macro "svc_stat" passed 4 arguments, but takes just 1
               dict_t *xdata)
                            ^
    snapview-client.c:560:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘{’ token
     {
     ^
    snapview-client.c:2412:26: error: ‘svc_stat’ undeclared here (not in a function)
             .stat          = svc_stat,
                              ^

svc_* is the common prefix for (SUN)RPC functions provided by system
headers. svc_stat() seems to be an existing function name. This happens
because change-id I98fc8cf7e4b631082c7b203b5a0a77111bec1fb9 causes
 included through "glusterfs.h". Prepending gf_ for all svc_*
functions works around the symbol collision.

Change-Id: Idc86b719c48675a5154c54d844c1899d14d46e2a
BUG: 1328502
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/14035
Smoke: Gluster Build System 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Kaleb KEITHLEY 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

gluster/uss: change ctime attr of a dir when USS enabled

2016-03-10T10:44:27+00:00

Consider a testcase:
 mount -t nfs host1:/vol1 /mnt
 ls /mnt
 ls /mnt/.snaps (As expected this fails)
 gluster volume set vol1 features.uss enable

Now `ls /mnt/.snaps` should work, but fails with No such file or
directory.
This is because NFS client  and Kernel VFS caches the list of files in a
directory.
This cache is updated if there are any changes in the directory attributes.

This patch solves the problem by changing ctime attribute when USS is
enabled

Change-Id: I48b284100d0589f1c0285782a1302080c15d4e1f
BUG: 1163416
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/9106
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

USS: pre-existing .snaps should not be listed with 'ls -a' with USS enabled

2016-02-15T08:16:33+00:00

If there is a .snaps directory pre-exists and when USS is enabled,
it should not be listed with 'ls -a'

Change-Id: I1c43e2decc0bbbd3213b190b675e3a32d04b22d3
BUG: 1303828
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/13330
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

snapview-client: remove check for parent inode type

2016-01-13T06:06:55+00:00

In lookup call back path, we are checking for parent inode
type to make sure parent inode was set properly, so that
next op on the inode can be successfuly completed.

More info can be found at bugid 1297311

Change-Id: Ifb1b17f472f855f9b12088c3dd8328389d895e77
BUG: 1297311
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/13227
Reviewed-by: Avra Sengupta 
Tested-by: NetBSD Build System 
Reviewed-by: Rajesh Joseph

features/snap : cleanup the root loc in statfs

2015-10-20T08:37:54+00:00

Problem : In svc_statfs function, wipe_loc is getting called on loc
          passed by nfs. This loc is being used by svc_stat which
          throws erro if loc->inode is NULL.

Solution : wipe_loc should be called on local root_loc.

Change-Id: I9cc5ee3b1bd9f352f2362a6d997b7b09051c0f68
BUG: 1260848
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/12123
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri