glusterfs.git/tests/bugs, branch v3.7.4

features/shard: Fix unlink failure due to non-existent shard(s)

2015-08-31T15:09:47+00:00

        Backport of: http://review.gluster.org/#/c/12059/

Unlink of a sharded file with holes was leading to EINVAL errors
because it was being wound on non-existent shards (those blocks that
fall in the hole region). loc->inode was NULL in these cases and
dht_unlink used to fail the FOP with EINVAL for failure to fetch
cached subvol for the inode.

The fix involves winding unlink on only those shards whose corresponding
inodes exist in memory.

Change-Id: I1e5d492a2e60491601da23f64a5d0089e536b305
BUG: 1258353
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/12061
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

afr: modify afr_txn_nothing_failed()

2015-08-31T15:03:09+00:00

Backport of http://review.gluster.org/#/c/11827/

In an AFR transaction, we need to consider something as failed only if the
failure (either in the pre-op or the FOP phase) occurs on the bricks on which a
transaction lock was obtained.

Without this, we would end up considering the transaction as failure even on the
bricks on which the lock was not obtained, resulting in unnecessary fsyncs
during the post-op phase of every write transaction for non-appending writes.

Change-Id: Iee79e5d85dc7b4c41459d8bdd04a8454bdaf9a9d
BUG: 1255698
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/11985
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: NetBSD Build System

features/shard: Fix permission issues

2015-08-31T09:31:10+00:00

        Backport of: http://review.gluster.org/11992

This patch does the following:
* reverts commit b467af0e99b39ef708420d3f7f6696b0ca618512
* changes ownership on shards under /.shard to be root:root
* makes readv, writev, [f]truncate, rename, and unlink fops
  to perform operations on files under /.shard with
  frame->root->{uid,gid} as 0.

This would ensure that a [f]setattr on a sharded file
does not need to be called on all the shards associated with it.

Change-Id: I50d8533bd2b769a4dfe8cd1b49bdcfc117a7e660
BUG: 1253151
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/12052
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System

features/shard: Fix size update for writes at hole region

2015-08-30T06:51:50+00:00

        Backport of: http://review.gluster.org/#/c/12020

Change-Id: I4b6e9101ccb881d3d285704902484e1e89ccaceb
BUG: 1257204
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/12026
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System

glusterd: Don't allow remove brick start/commit if glusterd is down of the host of the brick

2015-08-28T09:02:29+00:00

Backport of http://review.gluster.org/#/c/11726/

remove brick stage blindly starts the remove brick operation even if the
glusterd instance of the node hosting the brick is down. Operationally its
incorrect and this could result into a inconsistent rebalance status across all
the nodes as the originator of this command will always have the rebalance
status to 'DEFRAG_NOT_STARTED', however when the glusterd instance on the other
nodes comes up, will trigger rebalance and make the status to completed once the
rebalance is finished.

This patch fixes two things:
1. Add a validation in remove brick to check whether all the peers hosting the
bricks to be removed are up.

2. Don't copy volinfo->rebal.dict from stale volinfo during restore as this
might end up in a incosistent node_state.info file resulting into volume status
command failure.

Change-Id: Ia4a76865c05037d49eec5e3bbfaf68c1567f1f81
BUG: 1256265
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11726
Tested-by: NetBSD Build System 
Reviewed-by: N Balachandran 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11996
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

cluster/afr : Examine data/metadata readable for read-subvol

2015-08-28T07:13:16+00:00

During lookup and discover, currently read_subvol is based
only on data_readable. read_subvol should be decided based
on both data_readable and metadata_readable.

Credits to Ravishankar N for the logic of afr_first_up_child
from http://review.gluster.org/10905/ .

> Change-Id: I98580b23c278172ee2902be08eeaafb6722e830c
> BUG: 1240244
> Signed-off-by: Anuradha Talur 
> Reviewed-on: http://review.gluster.org/11551
> Reviewed-by: Ravishankar N 
> Tested-by: Gluster Build System 
> Reviewed-by: Krutika Dhananjay 
> Reviewed-by: Pranith Kumar Karampuri 
> (cherry picked from commit 36349fa250ace6109002dfa41305d9dcd54ce0a9)

Change-Id: Ia068ef9deb97f7bc48ea0c56d5ab6851f8860118
BUG: 1256909
Signed-off-by: Anuradha Talur 
Reviewed-on: http://review.gluster.org/12011
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System

glusterd: stop all the daemons services on peer detach

2015-08-26T11:58:03+00:00

Backport of:  http://review.gluster.org/#/c/11509/

Currently glusterd is not stopping all the deamon service on peer detach

With this fix it will do peer detach cleanup properlly and will stop all
the daemon which was running before peer detach on the node.

Change-Id: Ifed403ed09187e84f2a60bf63135156ad1f15775
BUG: 1238706
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11971
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Krishnan Parthasarathi

quota/marker: fix inode quota with rename

2015-08-21T05:45:35+00:00

This is a backport of http://review.gluster.org/11578

There are three problems with marker-rename which
is fixed in this patch

Problem 1)
1) mq_reduce_parent_size is not handling inode-quota contribution
2) When dest files exists and IO is happening
   Now renaming will overwrite existing file
   mq_reduce_parent_size called on dest file
   with saved contribution, this can be
   a problem is IO is still happening
   contribution might have changed

Problem 2)
There is a small race between rename and in-progress write
Consider below scenario
1) rename FOP invoked on file 'x'
2) write is still in progress for file 'x'
3) rename takes a lock on old-parent
4) write-update txn blocked on old-parent to acquire lock
5) in rename_cbk, contri xattrs are removed and contribution is deleted and
   lock is released
6) now write-update txn gets the lock and updates the wrong parent
   as it was holding lock on old parent
   so validate parent once the lock is acquired

Problem 3)
when a rename operation is performed, a lock is
held on old parent. This lock is release before
unwinding the rename operation.
This can be a problem if there are in-progress
writes happening during rename, where update txn
can take a lock and update the old parent
as inode table is not updated with new parent

> Change-Id: Ic3316097c001c33533f98592e8fcf234b1ee2aa2
> BUG: 1240991
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/11578
> Tested-by: Gluster Build System 
> Tested-by: NetBSD Build System 
> Reviewed-by: Raghavendra G 

Change-Id: Ie8e43c711a0e3dbe8494f0d64ab10c7b7a55e0d1
BUG: 1255244
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11961
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G

features/shard: Ensure shards are owned by the same owner/group as the original file

2015-08-19T09:27:32+00:00

        Backport of: http://review.gluster.org/#/c/11874/

Change-Id: I8c905917430c32eb2e6573968722920d3b27fb55
BUG: 1253151
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/11927
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

glusterd: Stop/restart/notify to daemons(svcs) during reset/set on a volume

2015-08-18T10:58:18+00:00

problem : Reset/set commands were not working properly. reset command returns
success but it not sending notification to svcs if corresponding graph modified.

Fix: Whenever reset/set command issued, generate the temp graph and compare
with original graph and do the fallowing actions
1.) If both graph are identical nothing to do with svcs.
2.) If any changes in graph topology restart/stop service by calling
svc manager.
3)  If changes in options send notify signal by calling glusterd_fetchspec_notify.

Back port of:
>Change-Id: I852c4602eafed1ae6e6a02424814fe3a83e3d4c7
>BUG: 1209329
>Signed-off-by: anand 
>Reviewed-on: http://review.gluster.org/10850
>Tested-by: NetBSD Build System 
>Tested-by: Gluster Build System 
>Reviewed-by: Atin Mukherjee 
>(cherry picked from commit 7255febab2c38cc89b71f2519a20d10f53586000)

Change-Id: I42aa757ecc6b5b307b5927d11f12d08f57ac0ae2
BUG: 1253165
Reviewed-on: http://review.gluster.org/11905
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee