glusterfs.git/tests/bugs, branch v3.6.3beta2

ec: Special handling of anonymous fd

2015-03-30T07:22:32+00:00

Anonymous file descriptors need to be handled specially because
they can be used in some non standard ways (i.e. an anonymous fd
can be used without having been opened).

This caused NFS to fail on some operations because ec always
expected to have a previous successful opendir call (from patch
http://review.gluster.org/9098/).

This patch treats all anonymous fd as opened on all subvolumes.

This is a backport of http://review.gluster.org/9513/

Change-Id: I09dbbce2ffc1ae3a5bcbb328bed55b84f4f0b9f8
BUG: 1187526
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9596
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Reviewed-by: Dan Lambright 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

afr: remove stale index entries

2015-03-25T08:57:01+00:00

Backport of http://review.gluster.org/9714

Problem:
During pre-op phase, the index xlator
1. Creates the entry inside .glusterfs/indices/xattrop
2. Winds the xattrop fop to posix to mark dirty/pending changelogs.
If the brick crashes after 1, the xattrop entry becomes stale and never
gets removed by shd during subsequent crawls because there is nothing to
heal (changelogs are zero).

Though the stale entry does not get displayed in the output of 'heal info'
command, it nevertheless stays there forever unless a new write tansaction
is performed on the file.

Fix:
During index self-heal if afr xattrs are found to be clean (indicated by
ret value of 2 on a call to afr_shd_selfheal(), send a dummy
post-op with all 0s for the xattr values, which makes the index xlator
to unlink the stale entry.

Change-Id: Iffb171e40490abd8d44df09ccc058b5da67baafe
BUG: 1203081
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/9920
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Raghavendra Bhat

glusterd/quota : remove quota-deem-statfs and quota-timeout values when quota is disabled.

2015-03-13T10:36:33+00:00

problem : If quota is disabled then all the options associated with
quota is removed, except quota-deem-statfs and quota-timeout.
When gluster volume info is issued then the user can see that quota
is disabled whereas quota-deem-statfs and quota-timeout values still
exist.

Solution : remove quota-deem-statfs and quota-timeout option when quota is
disabled

NOTE : If features.quota-deem-statfs is turned on, it takes quota limits
into consideration while estimating fs size.

Change-Id: I8cca6a8f47d2355799228643aedc8fc03896cfad
BUG: 1200258
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8924
Tested-by: Gluster Build System 
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/9845
Reviewed-by: Raghavendra Bhat

api: versioned symbols in libgfapi.so for compatibility

2015-03-04T07:32:16+00:00

Use versioned symbols to keep libgfapi at libgfapi.so.0.0.0

Revisited to address broken build on Mac OS X

See http://review.gluster.org/9055

Change-Id: I0f26668898749f57b61490b18f1f04c42996225d
BUG: 1165129
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/9145
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Gluster Build System 
Reviewed-by: Ravishankar N 
Reviewed-by: Raghavendra Bhat

glusterd: Maintain per transaction xaction_peers list in syncop & mgmt_v3

2015-02-26T12:00:32+00:00

In current implementation xaction_peers list is maintained in a global variable
(glustrd_priv_t) for syncop/mgmt_v3. This means consistency and atomicity of
peerinfo list across transactions is not guranteed when multiple syncop/mgmt_v3
transaction are going through.

We had got into a problem in mgmt_v3-locks.t which was failing spuriously, the
reason for that was two volume set operations (in two different volume) was
going through simultaneouly and both of these transaction were manipulating the
same xaction_peers structure which lead to a corrupted list. Because of which in
some cases unlock request to peer was never triggered and we end up with having
stale locks.

Solution is to maintain a per transaction local xaction_peers list for every
syncop.

Please note I've identified this problem in op-sm area as well and a separate
patch will be attempted to fix it.

Finally thanks to Krishnan Parthasarathi and Kaushal M for your constant help to
get to the root cause.

Backport URL : http://review.gluster.org/#/c/9269/
               http://review.gluster.org/#/c/9422/
               http://review.gluster.org/#/c/9350/
    
Change-Id: Ib1eaac9e5c8fc319f4e7f8d2ad965bc1357a7c63
BUG: 1176756
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9269
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-on: http://review.gluster.org/9328
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat

Fix for test uss.t and bug-1167580-set-proper-uid-and-gid-during-nfs-access.t

2015-02-24T06:46:56+00:00

testcase uss.t and
bug-1167580-set-proper-uid-and-gid-during-nfs-access.t
uses below method to generate random string
cat /dev/urandom | tr -dc 'a-zA-Z' | fold -w 8 | head -n 1

Doing a cat on /dev/urandom can consume more CPU usage.

Change to:
uuidgen | tr -dc 'a-zA-Z' | head -c 8

Backport of http://review.gluster.org/#/c/9703/

Change-Id: Id08ec47e39b12f956e266d30cc5327b5b70c2fb0
Reviewed-on: http://review.gluster.org/9728
BUG: 1165938
Signed-off-by: vmallika 
Reviewed-by: Justin Clift 
Tested-by: Justin Clift 
Reviewed-by: Raghavendra Bhat

ec: Don't use inodelk on getxattr when clearing locks

2015-02-11T09:40:11+00:00

When command 'clear-locks' from cli is executed, a getxattr request
is received by ec. This request was handled as usual, first locking
the inode. Once this request was processed by the bricks, all locks
were removed, including the lock used by ec.

When ec tried to unlock the previously acquired lock (which was
already released), caused a crash in glusterfsd.

This fix executes the getxattr request without any lock acquired
for the clear-locks command.

This is a backport of http://review.gluster.org/9440/

Change-Id: I77e550d13c4673d2468a1e13fe6e2fed20e233c6
BUG: 1181977
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9444
Reviewed-by: Dan Lambright 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

ec: Fix posix compliance failures

2015-02-11T09:37:55+00:00

This patch solves some problems that caused dispersed volumes to not
pass posix smoke tests:

* Problems in open/create with O_WRONLY
    Opening files with -w- permissions using O_WRONLY returned an EACCES
    error because internally O_WRONLY was replaced with O_RDWR.

* Problems with entrylk on renames.
    When source and destination were the same, ec tried to acquire
    the same entrylk twice, causing a deadlock.

* Overwrite of a variable when reordering locks.
    On a rename, if the second lock needed to be placed at the beggining
    of the list, the 'lock' variable was overwritten and later its timer
    was cancelled, cancelling the incorrect one.

* Handle O_TRUNC in open.
    When O_TRUNC was received in an open call, it was blindly propagated
    to child subvolumes. This caused a discrepancy between real file
    size and the size stored into trusted.ec.size xattr. This has been
    solved by removing O_TRUNC from open and later calling ftruncate.

This is a backport of http://review.gluster.org/9420

Change-Id: I20c3d6e1c11be314be86879be54b728e01013798
BUG: 1159471
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9501
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Raghavendra Bhat

ec: Fix failures with missing files

2015-02-11T09:20:24+00:00

When a file does not exist on a brick but it does on others, there
could be problems trying to access it because there was some loc_t
structures with null 'pargfid' but 'name' was set. This forced
inode resolution based on /name instead of  which
would be the correct one. To solve this problem, 'name' is always
set to NULL when 'pargfid' is not present.

Another problem was caused by an incorrect management of errors
while doing incremental locking. The only allowed error during an
incremental locking was ENOTCONN, but missing files on a brick can
be returned as ESTALE. This caused an EIO on the operation.

This patch doesn't care of errors during an incremental locking. At
the end of the operation it will check if there are enough successfully
locked bricks to continue or not.

This is a backport of http://review.gluster.org/9407/

Change-Id: I9360ebf8d819d219cea2d173c09bd37679a6f15a
BUG: 1183716
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9560
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Raghavendra Bhat

features/uss: Perform NULL check on @name in svc_getxattr

2015-01-09T05:00:40+00:00

        Backport of: http://review.gluster.org/9378

LISTXATTR fop is internally converted into a GETXATTR with
the "name" parameter set to NULL. In svc_getxattr(), a listxattr
was causing a crash because of a NULL pointer dereference on @name.

FIX:
Add the necessary NULL check.

Change-Id: Ifb4ca2a45ecc78c384e92822403eaf2f1b573798
BUG: 1180070
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9417
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat