glusterfs.git/tests/bugs/glusterd, branch v3.7.8

glusterd: import/export brickinfo->uuid

2016-01-14T09:35:05+00:00

Backport of http://review.gluster.org/#/c/13047/ 

    Given a two node cluster with node N1 & N2, if a dummy node N3 is peer probed, the
    probed node N3  goes for importing volumes from the probing node (N1), but
    it still doesn't have information about the other node (N2) about its membership
    (since peer update happens post volume updates) and hence fail to update its
    brick's uuid. Post that even though N2 updates N3 about its membership the
    brick's uuid was never generated. Now as a consequence when N3 initiates a
    detach of N2, it checks whether the node to be detached has any bricks
    configured by its respective uuid which is NULL in this case and hence it goes
    ahead and removes the peer which ideally it shouldn't have (refer to
    glusterd_friend_contains_vol_bricks () for the logic)
    
    Fix is to export brick's uuid and import it at the probed node instead of
    resolving it.

Change-Id: I2d88c72175347550a45ab12aff0ae248e56baa87
BUG: 1297305
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13047
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Gaurav Kumar Garg 
Reviewed-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13210

Tier/cli: Change detach-tier commit force to detach-tier force

2015-10-08T05:41:22+00:00

Current detach-tier cli command support commit force.
Deprecating the same to force.

So the new syntax would be:

volume detach-tier   

Back port of>

>Change-Id: Ie86dfd72341078c0a1be94767f523730911312ef
>BUG: 1261862
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/12151
>Tested-by: NetBSD Build System 
>Tested-by: Gluster Build System 
>Reviewed-by: Dan Lambright 
>Tested-by: Dan Lambright 

(cherry picked from commit 68e8d617eb62a7ec40a1db5f3f60730767a168b6)

Change-Id: I5b72dd0046fcf2ead74f7d1275f35036cce3195b
BUG: 1258242
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/12246
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: Do not allow "detach-tier commit" unnecessarily

2015-09-10T00:06:17+00:00

Backport of: http://review.gluster.org/#/c/12107/

Currently when user execute gluster v detach-tier commit command without
starting detach-tier or without giving force option then gluster will
success this operation.

Detach-tier commit should not allow without giving "force" optioin.

    >>Reviewed-on: http://review.gluster.org/12107
    >>Tested-by: NetBSD Build System 
    >>Tested-by: Gluster Build System 
    >>Reviewed-by: Atin Mukherjee 
    >>Reviewed-by: Dan Lambright 

Change-Id: Id161c288f6f3e0f6b298878a5c35a49fcbd9c6e3
BUG: 1259694
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/12108
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Tested-by: Dan Lambright

glusterd: Don't allow remove brick start/commit if glusterd is down of the host of the brick

2015-08-28T09:02:29+00:00

Backport of http://review.gluster.org/#/c/11726/

remove brick stage blindly starts the remove brick operation even if the
glusterd instance of the node hosting the brick is down. Operationally its
incorrect and this could result into a inconsistent rebalance status across all
the nodes as the originator of this command will always have the rebalance
status to 'DEFRAG_NOT_STARTED', however when the glusterd instance on the other
nodes comes up, will trigger rebalance and make the status to completed once the
rebalance is finished.

This patch fixes two things:
1. Add a validation in remove brick to check whether all the peers hosting the
bricks to be removed are up.

2. Don't copy volinfo->rebal.dict from stale volinfo during restore as this
might end up in a incosistent node_state.info file resulting into volume status
command failure.

Change-Id: Ia4a76865c05037d49eec5e3bbfaf68c1567f1f81
BUG: 1256265
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11726
Tested-by: NetBSD Build System 
Reviewed-by: N Balachandran 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11996
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

glusterd: stop all the daemons services on peer detach

2015-08-26T11:58:03+00:00

Backport of:  http://review.gluster.org/#/c/11509/

Currently glusterd is not stopping all the deamon service on peer detach

With this fix it will do peer detach cleanup properlly and will stop all
the daemon which was running before peer detach on the node.

Change-Id: Ifed403ed09187e84f2a60bf63135156ad1f15775
BUG: 1238706
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11971
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Krishnan Parthasarathi

glusterd: Stop/restart/notify to daemons(svcs) during reset/set on a volume

2015-08-18T10:58:18+00:00

problem : Reset/set commands were not working properly. reset command returns
success but it not sending notification to svcs if corresponding graph modified.

Fix: Whenever reset/set command issued, generate the temp graph and compare
with original graph and do the fallowing actions
1.) If both graph are identical nothing to do with svcs.
2.) If any changes in graph topology restart/stop service by calling
svc manager.
3)  If changes in options send notify signal by calling glusterd_fetchspec_notify.

Back port of:
>Change-Id: I852c4602eafed1ae6e6a02424814fe3a83e3d4c7
>BUG: 1209329
>Signed-off-by: anand 
>Reviewed-on: http://review.gluster.org/10850
>Tested-by: NetBSD Build System 
>Tested-by: Gluster Build System 
>Reviewed-by: Atin Mukherjee 
>(cherry picked from commit 7255febab2c38cc89b71f2519a20d10f53586000)

Change-Id: I42aa757ecc6b5b307b5927d11f12d08f57ac0ae2
BUG: 1253165
Reviewed-on: http://review.gluster.org/11905
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee

glusterd: getting txn_id from frame->cookie in op_sm call back

2015-08-07T06:24:22+00:00

RCA: If rebalance start is triggered from one node and one of other nodes in the cluster goes down simultaneously
we might end up in a case where callback will use the txn_id from priv->global_txn_id which is always zeros and
this means injecting an event with an incorrect txn_id will result into op-sm getting stuck.

fix: set txn_id in frame->cookie during sumbit_and_request, so that we can get txn_id in call back
functions.
Back port of :
>Change-Id: I519176c259ea9d37897791a77a7c92eb96d10052
>BUG: 1245142
>Signed-off-by: anand 
>Reviewed-on: http://review.gluster.org/11728
>Reviewed-by: Atin Mukherjee 
>Tested-by: NetBSD Build System 
>Tested-by: Gluster Build System 
>(cherry picked from commit 65e6ab1bfbbec7755f7ae2294cb83334ac65a296)

Change-Id: I376d6c791b0200a8371f590d29c3e950658a02c7
BUG: 1249925
Reviewed-on: http://review.gluster.org/11823
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: rebalance support for cluster.rc framework

2015-08-06T12:13:30+00:00

Issue:Rebalance is failing in cluster framework (any simulated cluster environment in same node ).
RCA:
  1. we are passing always "localhost" as volfile server for rebalance xlator .
  2. Rebalance daemons are overwriting  unix socket and log files each other.
     (All rebalance processes are creating socket with same name) .

Fix: set vol_file_server, unix socket and log files properly.
Back portof:
>Change-Id: I6654461e00c2a164b2f1f1db24a316c4180dd8d5
>BUG: 1231437
>Signed-off-by: anand 
>Reviewed-on: http://review.gluster.org/11210
>Tested-by: NetBSD Build System 
>Tested-by: Gluster Build System 
>Reviewed-by: Raghavendra G 
>Reviewed-by: Atin Mukherjee 
>(cherry picked from commit ee824ccb10e28489907fbf978a2d36b0b2c5dc8c)

Change-Id: I31a97c6186efa36d568c469a2320a4f3e870f781
BUG: 1249983
Reviewed-on: http://review.gluster.org/11824
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee

glusterd: initialize the daemon services on demand

2015-07-27T14:31:30+00:00

Backport of http://review.gluster.org/#/c/11488/

As of now all the daemon services are initialized at glusterD init path. Since
socket file path of per node daemon demands the uuid of the node, MY_UUID macro
is invoked as part of the initialization.

The above flow breaks the usecases where a gluster image is built following a
template could be Dockerfile, Vagrantfile or any kind of virtualization
environment. This means bringing instances of this image would have same UUIDs
for the node resulting in peer probe failure.

Solution is to lazily initialize the services on demand.

Change-Id: If7caa533026c83e98c7c7678bded67085d0bbc1e
BUG: 1247012
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11488
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Gaurav Kumar Garg 
Reviewed-by: Kaushal M 
Reviewed-on: http://review.gluster.org/11766

glusterd: Pass NULL in glusterd_svc_manager in glusterd_restart_bricks

2015-07-24T03:51:38+00:00

On restarting glusterd quota daemon is not started when  more than one
volumes are configured and quota is enabled only on 2nd volume.
This is because of while restarting glusterd it will restart all the bricks.
During brick restart it will start respective daemon by passing volinfo of
first volume. Passing volinfo to glusterd_svc_manager will imply daemon
managers will take action based on the same volume's configuration which
is incorrect for per node daemons.

Fix is to pass volinfo NULL while restarting bricks.

BUG: 1242882
Change-Id: Ie53fc452dc79811068a9397abca13c65de4a8359
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11660
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee